🐛 Source JIra: validation error for date-time format, 404 error in success rates #30515

darynaishchenko · 2023-09-18T10:43:45Z

What

Validation errors: validation_error:_.created:_2023-03-13t23:00:18.202-0700_is_an_invalid_date-time from dashboard.
Success rates:

401 client error - fixed in previous PR, handled as config error
403 forbidden - fixed in previous PR, added user message with step how to fix it
404 not found - was raised because of invalid domain

How

validation_error - added date time transformer that converts to isoformat if item has date-time in json schema, not convert other items
404 not found - handled as config error with user message.

github-actions · 2023-09-18T10:44:05Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

github-actions · 2023-09-18T10:54:28Z

source-jira test report (commit `0c86e0a6af`) - ❌

⏲️ Total pipeline duration: 08mn41s

Step	Result
Connector package install	✅
Build source-jira docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-jira/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

github-actions · 2023-09-18T11:05:00Z

source-jira test report (commit `13cc8e045d`) - ❌

⏲️ Total pipeline duration: 08mn16s

Step	Result
Connector package install	✅
Build source-jira docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-jira/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

…ss-rates

github-actions · 2023-09-18T13:35:05Z

source-jira test report (commit `c7f818f8d9`) - ✅

⏲️ Total pipeline duration: 09mn28s

Step	Result
Connector package install	✅
Build source-jira docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-jira/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

davydov-d · 2023-09-18T15:37:09Z

airbyte-integrations/connectors/source-jira/integration_tests/invalid_config.json

@@ -1,6 +1,5 @@
 {
  "api_token": "invalid_token",
-  "domain": "invaliddomain.atlassian.net",


why did you remove domain from here?

because this domain do not exist, and for this case we need to raise a config error, which not return (False, reason) as CAT expects, so to pass this test I removed one item to make this config invalid.

airbyte-integrations/connectors/source-jira/acceptance-test-config.yml

…ss-rates

github-actions · 2023-09-19T17:11:57Z

source-jira test report (commit `c1a5b86466`) - ❌

⏲️ Total pipeline duration: 09mn21s

Step	Result
Connector package install	✅
Build source-jira docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-jira/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

github-actions · 2023-09-19T17:22:15Z

source-jira test report (commit `4560d0b714`) - ❌

⏲️ Total pipeline duration: 08mn36s

Step	Result
Connector package install	✅
Build source-jira docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-jira/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

…ss-rates

github-actions · 2023-09-19T18:20:32Z

source-jira test report (commit `685c6ce1b1`) - ✅

⏲️ Total pipeline duration: 09mn30s

Step	Result
Connector package install	✅
Build source-jira docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-jira/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

darynaishchenko added 4 commits September 18, 2023 13:27

added datetime transformer

83b6ee3

added 404 error handling for check

e62f163

updated expected records

f52a128

updated connector version

0c86e0a

darynaishchenko self-assigned this Sep 18, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/jira labels Sep 18, 2023

updated changelog

13cc8e0

darynaishchenko added checklist-action-run and removed checklist-action-run labels Sep 18, 2023

darynaishchenko added 2 commits September 18, 2023 15:06

updated invalid config file

c85d35c

Merge branch 'master' into daryna/source-jira/validation-errors-succe…

c7f818f

…ss-rates

darynaishchenko requested review from lazebnyi, davydov-d and artem1205 September 18, 2023 13:54

davydov-d reviewed Sep 18, 2023

View reviewed changes

davydov-d approved these changes Sep 18, 2023

View reviewed changes

lazebnyi approved these changes Sep 19, 2023

View reviewed changes

airbyte-integrations/connectors/source-jira/acceptance-test-config.yml Outdated Show resolved Hide resolved

darynaishchenko added 2 commits September 19, 2023 20:00

Merge branch 'master' into daryna/source-jira/validation-errors-succe…

c1a5b86

…ss-rates

updated bypass reason

4560d0b

darynaishchenko added 2 commits September 19, 2023 21:03

updated expected records for issues stream

3b7faed

Merge branch 'master' into daryna/source-jira/validation-errors-succe…

685c6ce

…ss-rates

darynaishchenko merged commit 29d2c6b into master Sep 19, 2023
23 of 24 checks passed

darynaishchenko deleted the daryna/source-jira/validation-errors-success-rates branch September 19, 2023 18:32

dalebradman mentioned this pull request Sep 20, 2023

✨ Adding images and videos streams to TikTok Marketing connector tryarcane/airbyte#1

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source JIra: validation error for date-time format, 404 error in success rates #30515

🐛 Source JIra: validation error for date-time format, 404 error in success rates #30515

darynaishchenko commented Sep 18, 2023

github-actions bot commented Sep 18, 2023 •

edited by darynaishchenko

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

davydov-d Sep 18, 2023

darynaishchenko Sep 18, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

github-actions bot commented Sep 19, 2023

🐛 Source JIra: validation error for date-time format, 404 error in success rates #30515

🐛 Source JIra: validation error for date-time format, 404 error in success rates #30515

Conversation

darynaishchenko commented Sep 18, 2023

What

How

github-actions bot commented Sep 18, 2023 • edited by darynaishchenko

Before Merging a Connector Pull Request

github-actions bot commented Sep 18, 2023

source-jira test report (commit 0c86e0a6af) - ❌

github-actions bot commented Sep 18, 2023

source-jira test report (commit 13cc8e045d) - ❌

github-actions bot commented Sep 18, 2023

source-jira test report (commit c7f818f8d9) - ✅

davydov-d Sep 18, 2023

Choose a reason for hiding this comment

darynaishchenko Sep 18, 2023

Choose a reason for hiding this comment

github-actions bot commented Sep 19, 2023

source-jira test report (commit c1a5b86466) - ❌

github-actions bot commented Sep 19, 2023

source-jira test report (commit 4560d0b714) - ❌

github-actions bot commented Sep 19, 2023

source-jira test report (commit 685c6ce1b1) - ✅

github-actions bot commented Sep 18, 2023 •

edited by darynaishchenko

source-jira test report (commit `0c86e0a6af`) - ❌

source-jira test report (commit `13cc8e045d`) - ❌

source-jira test report (commit `c7f818f8d9`) - ✅

source-jira test report (commit `c1a5b86466`) - ❌

source-jira test report (commit `4560d0b714`) - ❌

source-jira test report (commit `685c6ce1b1`) - ✅