Created check_requirements.sh #3028 #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nclsbayona
commented
Apr 26, 2021
Comment on lines
+1
to
+6
| printf "Docker "; | ||
| if [[ $(which docker) && $(docker --version) ]]; then | ||
| printf "is installed" | ||
| else | ||
| printf "needs to be installed" | ||
| fi; |
There was a problem hiding this comment.
instead of leaving these at github comments, you can add them as comments in the actual script. i think it's worth it because it will help the next person who reads it!
There was a problem hiding this comment.
actually. i take it back. since you're printing it, it's pretty clear what does what.
nclsbayona
commented
Apr 26, 2021
Comment on lines
+8
to
+24
| desired="14" | ||
| printf "Java "; | ||
| if [[ "$(which java)" && "$(java --version)" ]]; | ||
| then | ||
| printf "installed" | ||
| str="$(java --version)" | ||
| IFS=' ' read -ra array <<< "${str}" | ||
| version="${array[1]}" | ||
| if [[ "${version}" > "${desired}" || "${version}" == "${desired}" ]]; | ||
| then | ||
| printf " and functional" | ||
| else | ||
| printf " but not functional, must have version ${desired} at least" | ||
| fi | ||
| else | ||
| printf "not installed, must have version ${desired} at least" | ||
| fi; |
nclsbayona
commented
Apr 26, 2021
Comment on lines
+62
to
+67
| printf "JQ "; | ||
| if [[ $(which jq) && $(jq --version) ]]; then | ||
| printf "is installed" | ||
| else | ||
| printf "needs to be installed" | ||
| fi; |
nclsbayona
commented
Apr 26, 2021
Comment on lines
+26
to
+42
| desired="20.1" | ||
| printf "Pip "; | ||
| if [[ "$(which pip)" && "$(pip --version)" ]]; | ||
| then | ||
| printf "installed" | ||
| str="$(pip --version)" | ||
| IFS=' ' read -ra array <<< "${str}" | ||
| version="${array[1]}" | ||
| if [[ "${version}" > "${desired}" || "${version}" == "${desired}" ]]; | ||
| then | ||
| printf " and functional" | ||
| else | ||
| printf " but not functional, must have version ${desired} at least" | ||
| fi | ||
| else | ||
| printf "not installed, must have version ${desired} at least" | ||
| fi; |
nclsbayona
commented
Apr 26, 2021
Comment on lines
+44
to
+60
| desired="3.7.9" | ||
| printf "Python "; | ||
| if [[ "$(which python3)" && "$(python3 --version)" ]]; | ||
| then | ||
| printf "installed" | ||
| str="$(python3 --version)" | ||
| IFS=' ' read -ra array <<< "${str}" | ||
| version="${array[1]}" | ||
| if [[ "${version}" > "${desired}" || "${version}" == "${desired}" ]]; | ||
| then | ||
| printf " and functional" | ||
| else | ||
| printf " but not functional, must have version ${desired} at least" | ||
| fi | ||
| else | ||
| printf "not installed, must have version ${desired} at least" | ||
| fi; |
cgardens
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
it looks great, @nclsbayona ! thanks for contributing this. i left 1 very minor comment. once you address them, i'd be happy to merge this!
Comment on lines
+1
to
+6
| printf "Docker "; | ||
| if [[ $(which docker) && $(docker --version) ]]; then | ||
| printf "is installed" | ||
| else | ||
| printf "needs to be installed" | ||
| fi; |
There was a problem hiding this comment.
instead of leaving these at github comments, you can add them as comments in the actual script. i think it's worth it because it will help the next person who reads it!
|
Actually I think this is ready to go as it is! Merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Contributing what is asked for in #3028 .
How
To achieve a solution, a bash script was created in the directory ./tools/bin with the name check_requirements.sh
Pre-merge Checklist
Don't think there were any pre-requisites, since its new and it's not referenced by any other component.
Recommended reading order