Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airbyte-ci: Add migration guide from original for strict encrypt #30595

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented Sep 19, 2023

Problem

When publishing a strict-encrypt variant QA checks were failing as the migration guide for the base connector was not loaded into the container/

Solution

Add the migration guide to the container

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 10:34pm

@bnchrch bnchrch requested a review from a team September 19, 2023 22:31
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was very confused by this when I saw it! Is this a regression? I know I've added this exact line somewhere before.

In any case, thanks for fixing!

@erohmensing
Copy link
Contributor

erohmensing commented Sep 19, 2023

Ohhh. I added this line above it but missed it here. That makes sense!

https://github.com/airbytehq/airbyte/pull/30595/files#diff-660e2f67b2ffbce25dbe7ae914b451ab3a9d1fcb558f43b6cc4684fe8dda67b8R150

@erohmensing
Copy link
Contributor

insert death to strict encrypt

@bnchrch bnchrch merged commit 9fe7a54 into master Sep 19, 2023
22 checks passed
@bnchrch bnchrch deleted the bnchrch/fix/qa-check-step-strict-variant branch September 19, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants