Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Slack: add default value for channel filters during discover #30613

Merged

Conversation

arsenlosenko
Copy link
Contributor

What

Resolving issue described in this oncall issue:
https://github.com/airbytehq/oncall/issues/2865

How

Sync crashes on discover stage due to a fact that config does not have channel_filters, changed code a bit so this confg field would have a default value

@arsenlosenko arsenlosenko self-assigned this Sep 20, 2023
@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Sep 21, 2023 2:46pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/slack labels Sep 20, 2023
@github-actions
Copy link
Contributor

source-slack test report (commit 7e1268fefb) - ❌

⏲️ Total pipeline duration: 105mn11s

Step Result
Connector package install
Build source-slack docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-slack/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-slack test

@airbyte-oss-build-runner
Copy link
Collaborator

source-slack test report (commit 869cb6d0fc) - ❌

⏲️ Total pipeline duration: 54mn51s

Step Result
Connector package install
Build source-slack docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-slack/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-slack test

@airbyte-oss-build-runner
Copy link
Collaborator

source-slack test report (commit 98c0d11b62) - ✅

⏲️ Total pipeline duration: 54mn44s

Step Result
Connector package install
Build source-slack docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-slack/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-slack test

@arsenlosenko arsenlosenko merged commit c07c003 into master Sep 21, 2023
25 checks passed
@arsenlosenko arsenlosenko deleted the arsenlosenko/2865-optional-channel-filters-in-discover branch September 21, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants