Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Jira: certification updates: docs, project_permission_schemes stream, issues expand made as default #30688

Merged
merged 15 commits into from
Sep 28, 2023

Conversation

darynaishchenko
Copy link
Collaborator

@darynaishchenko darynaishchenko commented Sep 22, 2023

What

  • docs: Removed inapp.md, added Pull Request to incremental streams, removed issue expand
  • project_permission_schemes stream: updated unittest, fixed mocked data(it were duplicates with previous implementation, because of duplicated project ids)
  • spec - removed optional "issue expand", because it relates to implementation only, not user

@darynaishchenko darynaishchenko self-assigned this Sep 22, 2023
@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 7:51am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@airbyte-oss-build-runner
Copy link
Collaborator

source-jira test report (commit fc9a2587f2) - ❌

⏲️ Total pipeline duration: 16mn25s

Step Result
Connector package install
Build source-jira docker image for platform linux/x86_64
Unit tests
Code format checks
Validate airbyte-integrations/connectors/source-jira/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

@darynaishchenko darynaishchenko changed the title Source Jira: fixed tests for project related streams ✨ Source Jira: certification updates: docs, project_permission_schemes stream, issues expand made as default Sep 26, 2023
@airbyte-oss-build-runner
Copy link
Collaborator

source-jira test report (commit b57d0a1a74) - ✅

⏲️ Total pipeline duration: 10mn52s

Step Result
Connector package install
Build source-jira docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-jira/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

Copy link
Collaborator

@artem1205 artem1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove MigrateIssueExpandProperties from main.py

@airbyte-oss-build-runner
Copy link
Collaborator

source-jira test report (commit 828f047df5) - ❌

⏲️ Total pipeline duration: 10mn37s

Step Result
Connector package install
Build source-jira docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-jira/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

@airbyte-oss-build-runner
Copy link
Collaborator

source-jira test report (commit 9d8690a315) - ✅

⏲️ Total pipeline duration: 10mn15s

Step Result
Connector package install
Build source-jira docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-jira/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/integrations/sources/jira.md Outdated Show resolved Hide resolved
@airbyte-oss-build-runner
Copy link
Collaborator

source-jira test report (commit f89bf42cb7) - ✅

⏲️ Total pipeline duration: 09mn19s

Step Result
Connector package install
Build source-jira docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-jira/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

@darynaishchenko darynaishchenko merged commit ee16847 into master Sep 28, 2023
28 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-jira/adding-tests branch September 28, 2023 08:08
girarda pushed a commit that referenced this pull request Oct 10, 2023
…s stream, issues expand made as default (#30688)

Co-authored-by: darynaishchenko <darynaishchenko@users.noreply.github.com>
girarda pushed a commit that referenced this pull request Oct 10, 2023
…s stream, issues expand made as default (#30688)

Co-authored-by: darynaishchenko <darynaishchenko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants