Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Facebook Marketing: Include socat binary in docker image #30706

Merged
merged 2 commits into from
Sep 23, 2023

Conversation

git-phu
Copy link
Contributor

@git-phu git-phu commented Sep 22, 2023

What

This is for

How

Build and publish source Facebook Marketing to include socat in the docker image.
This will then be used in https://github.com/airbytehq/airbyte-platform-internal/pull/8870

🚨 User Impact 🚨

None from this PR alone (socat will be added to the image but won't be used until https://github.com/airbytehq/airbyte-platform-internal/pull/8870 is merged.)

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
airbyte-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 22, 2023 10:59pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing labels Sep 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! πŸŽ‰

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@git-phu git-phu marked this pull request as ready for review September 22, 2023 22:57
@git-phu git-phu requested review from gosusnp and a team September 22, 2023 22:58
Copy link
Contributor

@gosusnp gosusnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd rather make sure someone from connectors take a look.
Looking at the dockerfile, shouldn't we have a base image for python cdk based connectors instead of rebuilding everything from scratch?

@git-phu
Copy link
Contributor Author

git-phu commented Sep 22, 2023

Looking at the dockerfile, shouldn't we have a base image for python cdk based connectors instead of rebuilding everything from scratch?

@gosusnp yes, connector ops is actually in the middle of recreating the bases too, so for general rollout we'll need to add it there. This is just for testing on specific existing connector Dockerfiles

Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@git-phu git-phu enabled auto-merge (squash) September 22, 2023 23:20
@airbyte-oss-build-runner
Copy link
Collaborator

source-facebook-marketing test report (commit aa32310b16) - βœ…

⏲️ Total pipeline duration: 102mn27s

Step Result
Connector package install βœ…
Build source-facebook-marketing docker image for platform linux/x86_64 βœ…
Unit tests βœ…
Integration tests βœ…
Acceptance tests βœ…
Code format checks βœ…
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml βœ…
Connector version semver check βœ…
Connector version increment check βœ…
QA checks βœ…

πŸ”— View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@git-phu git-phu merged commit 3af9ad2 into master Sep 23, 2023
31 of 34 checks passed
@git-phu git-phu deleted the peter/socat-fb-marketing branch September 23, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants