Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Jira: add new stream Issue custom field options, IssueTypes, Project Roles #30755

Merged
merged 12 commits into from Sep 27, 2023

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Sep 26, 2023

What

Resolving #29742

How

Add new Streams:

  • IssueTypes
  • Project Roles
  • Issue custom field options

Recommended reading order

  1. streams.py

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2023 1:15pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! πŸŽ‰

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205 artem1205 changed the title Source Jira: add new stream IssueTypes Source Jira: add new stream IssueTypes, Project Roles Sep 26, 2023
@artem1205 artem1205 changed the title Source Jira: add new stream IssueTypes, Project Roles Source Jira: add new stream Issue custom field options, IssueTypes, Project Roles Sep 26, 2023
@artem1205 artem1205 changed the title Source Jira: add new stream Issue custom field options, IssueTypes, Project Roles ✨ Source Jira: add new stream Issue custom field options, IssueTypes, Project Roles Sep 26, 2023
@artem1205 artem1205 self-assigned this Sep 26, 2023
@artem1205 artem1205 marked this pull request as ready for review September 26, 2023 16:11
@airbyte-oss-build-runner
Copy link
Collaborator

source-jira test report (commit 6ea6e5ad9d) - ❌

⏲️ Total pipeline duration: 47.98s

Step Result
Connector package install βœ…
Build source-jira docker image for platform linux/x86_64 βœ…
Unit tests ❌
Code format checks βœ…
Validate airbyte-integrations/connectors/source-jira/metadata.yaml βœ…
Connector version semver check βœ…
Connector version increment check βœ…
QA checks βœ…

πŸ”— View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

@airbyte-oss-build-runner
Copy link
Collaborator

source-jira test report (commit f47f43bb69) - ❌

⏲️ Total pipeline duration: 09mn17s

Step Result
Connector package install βœ…
Build source-jira docker image for platform linux/x86_64 βœ…
Unit tests βœ…
Integration tests βœ…
Acceptance tests ❌
Code format checks βœ…
Validate airbyte-integrations/connectors/source-jira/metadata.yaml βœ…
Connector version semver check βœ…
Connector version increment check βœ…
QA checks βœ…

πŸ”— View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

@airbyte-oss-build-runner
Copy link
Collaborator

source-jira test report (commit 648e5a2607) - ❌

⏲️ Total pipeline duration: 09mn41s

Step Result
Connector package install βœ…
Build source-jira docker image for platform linux/x86_64 βœ…
Unit tests βœ…
Integration tests βœ…
Acceptance tests ❌
Code format checks βœ…
Validate airbyte-integrations/connectors/source-jira/metadata.yaml βœ…
Connector version semver check βœ…
Connector version increment check βœ…
QA checks βœ…

πŸ”— View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

@airbyte-oss-build-runner
Copy link
Collaborator

source-jira test report (commit 9299a33346) - ❌

⏲️ Total pipeline duration: 10mn20s

Step Result
Connector package install βœ…
Build source-jira docker image for platform linux/x86_64 βœ…
Unit tests βœ…
Integration tests βœ…
Acceptance tests ❌
Code format checks βœ…
Validate airbyte-integrations/connectors/source-jira/metadata.yaml βœ…
Connector version semver check βœ…
Connector version increment check βœ…
QA checks βœ…

πŸ”— View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

@airbyte-oss-build-runner
Copy link
Collaborator

source-jira test report (commit f3006ded59) - βœ…

⏲️ Total pipeline duration: 05mn55s

Step Result
Connector package install βœ…
Build source-jira docker image for platform linux/x86_64 βœ…
Unit tests βœ…
Integration tests βœ…
Acceptance tests βœ…
Code format checks βœ…
Validate airbyte-integrations/connectors/source-jira/metadata.yaml βœ…
Connector version semver check βœ…
Connector version increment check βœ…
QA checks βœ…

πŸ”— View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

@artem1205 artem1205 merged commit f2421ec into master Sep 27, 2023
28 checks passed
@artem1205 artem1205 deleted the artem1205/source-jira-add-streams branch September 27, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/jira team/connectors-python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants