🎉 Sources Facebook Marketing and Google Ads: not raise an exception if a stream is not found #30758

yevhenii-ldv · 2023-09-26T14:58:14Z

What

Resolve issue #30701.

How

Set raise_exception_on_missing_stream=False for Source classes

Pre-merge Actions

Unit & integration tests added
Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

vercel · 2023-09-26T14:58:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Sep 27, 2023 3:08pm

github-actions · 2023-09-26T14:58:38Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

airbyte-oss-build-runner · 2023-09-26T15:06:28Z

source-facebook-marketing test report (commit `d8d39a77c6`) - ❌

⏲️ Total pipeline duration: 03mn34s

Step	Result

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

airbyte-oss-build-runner · 2023-09-26T15:13:24Z

source-google-ads test report (commit `d8d39a77c6`) - ❌

⏲️ Total pipeline duration: 08mn50s

Step	Result
Connector package install	✅
Build source-google-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

airbyte-oss-build-runner · 2023-09-26T15:25:12Z

source-google-ads test report (commit `9a6627c435`) - ❌

⏲️ Total pipeline duration: 07mn45s

Step	Result
Connector package install	✅
Build source-google-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

airbyte-oss-build-runner · 2023-09-26T16:58:28Z

source-facebook-marketing test report (commit `9a6627c435`) - ✅

⏲️ Total pipeline duration: 101mn38s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

girarda

change looks good. looking into why CI is failing...

…oogle-ads-should-not-raise-an-exception-if-a-stream-is-not-found

airbyte-oss-build-runner · 2023-09-26T17:45:50Z

source-google-ads test report (commit `b7d971ece9`) - ❌

⏲️ Total pipeline duration: 02mn52s

Step	Result
Connector package install	✅
Build source-google-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

…f a stream is not found

…/source-facebook-marketing-and-google-ads-should-not-raise-an-exception-if-a-stream-is-not-found # Conflicts: # airbyte-integrations/connectors/source-google-ads/unit_tests/test_source.py

airbyte-oss-build-runner · 2023-09-26T19:17:32Z

source-facebook-marketing test report (commit `b7d971ece9`) - ✅

⏲️ Total pipeline duration: 94mn34s

Step	Result
Connector package install	✅
Build source-facebook-marketing docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

girarda · 2023-09-27T14:49:15Z

the tests for google-ads do not pass on master either. Ok to merge as is since the change is fairly straightforward and you were able to test on facebook-marketing

…/source-facebook-marketing-and-google-ads-should-not-raise-an-exception-if-a-stream-is-not-found

…uld-not-raise-an-exception-if-a-stream-is-not-found' of github.com:airbytehq/airbyte into ykurochkin/source-facebook-marketing-and-google-ads-should-not-raise-an-exception-if-a-stream-is-not-found

girarda · 2023-09-27T15:08:21Z

/approve-and-merge reason="CATs for google-ads are also failing on master"

octavia-approvington · 2023-09-27T15:08:59Z

Lets do it!

octavia-squidington-iii added area/connectors Connector related issues connectors/source/facebook-marketing connectors/source/google-ads labels Sep 26, 2023

yevhenii-ldv changed the title ~~Facebook Marketing and Google Ads sources should not raise an exception if a stream is not found~~ 🎉 Sources Facebook Marketing and Google Ads: not raise an exception if a stream is not found Sep 26, 2023

yevhenii-ldv requested review from girarda and keu September 26, 2023 15:03

vercel bot deployed to Preview September 26, 2023 15:12 View deployment

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Sep 26, 2023

vercel bot deployed to Preview September 26, 2023 15:26 View deployment

girarda approved these changes Sep 26, 2023

View reviewed changes

Merge branch 'master' into ykurochkin/source-facebook-marketing-and-g…

b7d971e

…oogle-ads-should-not-raise-an-exception-if-a-stream-is-not-found

vercel bot deployed to Preview September 26, 2023 17:44 View deployment

yevhenii-ldv added 3 commits September 26, 2023 17:51

Facebook-marketing and Google-Ads sources should raise an exception i…

29bcfa5

…f a stream is not found

Merge branch 'master' of github.com:airbytehq/airbyte into ykurochkin…

d8d39a7

…/source-facebook-marketing-and-google-ads-should-not-raise-an-exception-if-a-stream-is-not-found # Conflicts: # airbyte-integrations/connectors/source-google-ads/unit_tests/test_source.py

Increment connectors versions

9a6627c

yevhenii-ldv added 2 commits September 27, 2023 15:06

Merge branch 'master' of github.com:airbytehq/airbyte into ykurochkin…

3f04d0d

…/source-facebook-marketing-and-google-ads-should-not-raise-an-exception-if-a-stream-is-not-found

Merge branch 'ykurochkin/source-facebook-marketing-and-google-ads-sho…

3ed7718

…uld-not-raise-an-exception-if-a-stream-is-not-found' of github.com:airbytehq/airbyte into ykurochkin/source-facebook-marketing-and-google-ads-should-not-raise-an-exception-if-a-stream-is-not-found

octavia-approvington approved these changes Sep 27, 2023

View reviewed changes

octavia-approvington merged commit 3834b61 into master Sep 27, 2023
13 of 14 checks passed

octavia-approvington deleted the ykurochkin/source-facebook-marketing-and-google-ads-should-not-raise-an-exception-if-a-stream-is-not-found branch September 27, 2023 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Sources Facebook Marketing and Google Ads: not raise an exception if a stream is not found #30758

🎉 Sources Facebook Marketing and Google Ads: not raise an exception if a stream is not found #30758

yevhenii-ldv commented Sep 26, 2023

vercel bot commented Sep 26, 2023 •

edited

github-actions bot commented Sep 26, 2023 •

edited by yevhenii-ldv

airbyte-oss-build-runner commented Sep 26, 2023

airbyte-oss-build-runner commented Sep 26, 2023

airbyte-oss-build-runner commented Sep 26, 2023

airbyte-oss-build-runner commented Sep 26, 2023

girarda left a comment

airbyte-oss-build-runner commented Sep 26, 2023

airbyte-oss-build-runner commented Sep 26, 2023

girarda commented Sep 27, 2023

girarda commented Sep 27, 2023 •

edited

octavia-approvington commented Sep 27, 2023

🎉 Sources Facebook Marketing and Google Ads: not raise an exception if a stream is not found #30758

🎉 Sources Facebook Marketing and Google Ads: not raise an exception if a stream is not found #30758

Conversation

yevhenii-ldv commented Sep 26, 2023

What

How

Recommended reading order

Pre-merge Actions

vercel bot commented Sep 26, 2023 • edited

github-actions bot commented Sep 26, 2023 • edited by yevhenii-ldv

Before Merging a Connector Pull Request

airbyte-oss-build-runner commented Sep 26, 2023

source-facebook-marketing test report (commit d8d39a77c6) - ❌

airbyte-oss-build-runner commented Sep 26, 2023

source-google-ads test report (commit d8d39a77c6) - ❌

airbyte-oss-build-runner commented Sep 26, 2023

source-google-ads test report (commit 9a6627c435) - ❌

airbyte-oss-build-runner commented Sep 26, 2023

source-facebook-marketing test report (commit 9a6627c435) - ✅

girarda left a comment

Choose a reason for hiding this comment

airbyte-oss-build-runner commented Sep 26, 2023

source-google-ads test report (commit b7d971ece9) - ❌

airbyte-oss-build-runner commented Sep 26, 2023

source-facebook-marketing test report (commit b7d971ece9) - ✅

girarda commented Sep 27, 2023

girarda commented Sep 27, 2023 • edited

octavia-approvington commented Sep 27, 2023

vercel bot commented Sep 26, 2023 •

edited

github-actions bot commented Sep 26, 2023 •

edited by yevhenii-ldv

source-facebook-marketing test report (commit `d8d39a77c6`) - ❌

source-google-ads test report (commit `d8d39a77c6`) - ❌

source-google-ads test report (commit `9a6627c435`) - ❌

source-facebook-marketing test report (commit `9a6627c435`) - ✅

source-google-ads test report (commit `b7d971ece9`) - ❌

source-facebook-marketing test report (commit `b7d971ece9`) - ✅

girarda commented Sep 27, 2023 •

edited