Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination snowflake: Fix regression from cdk publish race condition #30835

Merged
merged 7 commits into from
Sep 28, 2023

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Sep 28, 2023

0.1.0 ran into the publish race condition :(

publish 0.1.1 to include bases-destination-jdbc changes from #30599

closes #30492

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2023 6:19pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Sep 28, 2023
@edgao edgao marked this pull request as ready for review September 28, 2023 16:04
@edgao edgao requested a review from a team as a code owner September 28, 2023 16:04
@edgao edgao changed the title Republish java cdk Destination snowflake: Fix regression from cdk publish race condition Sep 28, 2023
@airbyte-oss-build-runner
Copy link
Collaborator

destination-snowflake test report (commit 368efa0a6a) - ✅

⏲️ Total pipeline duration: 10mn13s

Step Result
Build connector tar
Build destination-snowflake docker image for platform linux/x86_64
Java Connector Unit Tests
Java Connector Integration Tests
Validate metadata for destination-snowflake
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

@edgao
Copy link
Contributor Author

edgao commented Sep 28, 2023

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/6341884333
❌ Publish Java CDK version=0.1.1 failed!

@airbyte-oss-build-runner
Copy link
Collaborator

destination-snowflake test report (commit 9f53639924) - ✅

⏲️ Total pipeline duration: 03mn25s

Step Result
Build connector tar
Build destination-snowflake docker image for platform linux/x86_64
Java Connector Unit Tests
Java Connector Integration Tests
Validate metadata for destination-snowflake
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

@edgao
Copy link
Contributor Author

edgao commented Sep 28, 2023

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/6342576820
✅ Successfully published Java CDK version=0.1.1!

@airbyte-oss-build-runner
Copy link
Collaborator

destination-snowflake test report (commit 4648ab0f0a) - ✅

⏲️ Total pipeline duration: 10mn35s

Step Result
Build connector tar
Build destination-snowflake docker image for platform linux/x86_64
Java Connector Unit Tests
Java Connector Integration Tests
Validate metadata for destination-snowflake
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

@edgao edgao enabled auto-merge (squash) September 28, 2023 18:21
@airbyte-oss-build-runner
Copy link
Collaborator

destination-snowflake test report (commit b6aa114603) - ✅

⏲️ Total pipeline duration: 11mn06s

Step Result
Build connector tar
Build destination-snowflake docker image for platform linux/x86_64
Java Connector Unit Tests
Java Connector Integration Tests
Validate metadata for destination-snowflake
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

@edgao edgao merged commit 6d831f1 into master Sep 28, 2023
21 checks passed
@edgao edgao deleted the edgao/java_cdk_republish branch September 28, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/snowflake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destination snowflake (and maybe bigquery?): Create staging area with namespace
4 participants