Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source hubspot: Fix argument error in log call #3087

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

nyergler
Copy link
Contributor

What

When attempting to use an OAuth access token with the Hubspot source,
the logging call would cause the process to crash with an error:

TypeError: info() takes 2 positional arguments but 3 were given

How

Convert log message to proper Python f string.

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

When attempting to use an OAuth access token with the Hubspot source,
the logging call would cause the process to crash with an error:

```
TypeError: info() takes 2 positional arguments but 3 were given
```
@sherifnada
Copy link
Contributor

Thanks @nyergler !

@sherifnada sherifnada changed the base branch from master to sherif/land-3087 April 27, 2021 19:30
@sherifnada sherifnada changed the title Fix argument error in log call Source hubspot: Fix argument error in log call Apr 27, 2021
@sherifnada sherifnada merged commit d334288 into airbytehq:sherif/land-3087 Apr 27, 2021
@nyergler
Copy link
Contributor Author

No problem, @sherifnada. This is my first commit, just curious what the cadence is for things to land in master (and subsequently in the built Docker images).

sherifnada added a commit that referenced this pull request Apr 27, 2021
* Fix argument error in log call (#3087)

When attempting to use an OAuth access token with the Hubspot source,
the logging call would cause the process to crash with an error:

```
TypeError: info() takes 2 positional arguments but 3 were given
```

* bump

Co-authored-by: Nathan Yergler <nathan@yergler.net>
@sherifnada
Copy link
Contributor

sherifnada commented Apr 27, 2021

@nyergler this is now in master! See #3091

We do weekly releases, so anyone using a fresh instance of Airbyte will pick this up on the next release (I think our next one is today or tomorrow).

To use this on an existing Airbyte instance upgrade your connector to version 0.1.3 and get started. To upgrade your connector version, go to the admin panel in the left hand side of the UI, find this connector in the list, and input the latest connector version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants