Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Maijet: retrieve subject from messages stream #30924

Merged
merged 3 commits into from Dec 18, 2023
Merged

✨ Maijet: retrieve subject from messages stream #30924

merged 3 commits into from Dec 18, 2023

Conversation

mickaelandrieu
Copy link
Contributor

Hi,

the Mailjet connector is slow and uncomplete atm.

Regarding the completion of the fields, the Mailjet REST API disallow by default the sending of the message subject, this is why we should allow it => https://dev.mailjet.com/email/reference/messages#v3_get_message

Regards,

@vercel
Copy link

vercel bot commented Sep 29, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 5:38pm

@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@mickaelandrieu mickaelandrieu changed the title Allow Mailjet connector to retrieve message subjects ✨ Maijet: retrieve subject from messages stream Sep 29, 2023
@mickaelandrieu
Copy link
Contributor Author

mickaelandrieu commented Sep 29, 2023 •
edited

Hi !
I'll do all the extra required tasks to upgrade the connector if you think it will be merged.
I use n8n as a replacement for Airbyte, so I don't really need it to be merged anymore.

Regards,

@marcosmarxm
Copy link
Member

Thanks for the contribution @mickaelandrieu. Right now the team is dedicated to review Hackathon contribution during October. I added this to the backlog to revisit in the future.

@marcosmarxm marcosmarxm added the team/tse Technical Support Engineers label Oct 10, 2023
@mickaelandrieu
Copy link
Contributor Author

Hi, as it's a connector contribution... why not add it as part of the hackathon ? 😁

marcosmarxm
marcosmarxm requested changes Nov 22, 2023
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry the delay @mickaelandrieu I made a quick review.

airbyte-integrations/connectors/source-mailjet-mail/source_mailjet_mail/manifest.yaml Show resolved Hide resolved
@mickaelandrieu
Copy link
Contributor Author

ping @marcosmarxm :)

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Dec 18, 2023
@marcosmarxm marcosmarxm merged commit 4b7818c into airbytehq:master Dec 18, 2023
40 of 47 checks passed
@mickaelandrieu
Copy link
Contributor Author

Thank you @marcosmarxm 🤩

@mickaelandrieu mickaelandrieu deleted the patch-4 branch December 19, 2023 09:53
mickaelandrieu
mickaelandrieu commented Dec 19, 2023
View reviewed changes
docs/integrations/sources/mailjet-mail.md
@@ -34,5 +34,6 @@ Mailjet APIs are under rate limits for the number of API calls allowed per API k

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :-------------------------------------------------------- | :----------------------------------------- |
| 0.1.1 | 2022-04-19 | [#24689](https://github.com/airbytehq/airbyte/pull/24689) | Add listrecipient stream |
| 0.1.2 | 2022-12-18 | [#30924](https://github.com/airbytehq/airbyte/pull/30924) | Adds Subject field to `message` stream |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- 2022
+ 2023

I'll fix it later

timroes pushed a commit that referenced this pull request Dec 19, 2023
@mickaelandrieu @marcosmarxm @timroes
✨ Maijet: retrieve subject from messages stream (#30924)
77c467a 
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@mickaelandrieu @marcosmarxm @jatinyadav-cc
✨ Maijet: retrieve subject from messages stream (airbytehq#30924)
e10dcc3 
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@mickaelandrieu @marcosmarxm @jatinyadav-cc
✨ Maijet: retrieve subject from messages stream (airbytehq#30924)
7d613b4 
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@mickaelandrieu @marcosmarxm @jatinyadav-cc
✨ Maijet: retrieve subject from messages stream (airbytehq#30924)
64897cc 
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/mailjet-mail team/tse Technical Support Engineers
Projects
Community Contributed PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mickaelandrieu @marcosmarxm @octavia-squidington-iii