New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source PokeApi - Migrated to Low code #30969
✨ Source PokeApi - Migrated to Low code #30969
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Thanks for the contribution @avirajsingh7. I added it to the team backlog and we're planning to start next week the review process. |
enum: | ||
- bulbasaur | ||
- ivysaur | ||
- venusaur | ||
- charmander | ||
- charmeleon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the enum? During migration let's try to keep similar to previous behavior.
"type": "array", | ||
"items": { | ||
"type": "object", | ||
"properties": { | ||
"generation": { | ||
"type": "object", | ||
"properties": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"type": "array", | |
"items": { | |
"type": "object", | |
"properties": { | |
"generation": { | |
"type": "object", | |
"properties": { | |
"type": ["null", "array"], | |
"items": { | |
"type": ["null", "object"], | |
"additionalProperties": true, | |
"properties": { | |
"generation": { | |
"type": ["null", "object"], | |
"additionalProperties": true, | |
"properties": { |
Co-authored-by: Sajarin <sajarindider@gmail.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: Sajarin <sajarindider@gmail.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
What
Migrating Source PokeApi to Low-Code CDK
Closes #30870
How
Developed using (Configuration Based Source) low-code CDK
Recommended reading order
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
added some new properties in schema as per response from API
Test
Acceptance Test
Migrate Connector : Source PokeApi