Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source GitHub: limit backoff time to 10 minutes #30970

Closed
wants to merge 7 commits into from
Closed

Source GitHub: limit backoff time to 10 minutes #30970

wants to merge 7 commits into from

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Oct 2, 2023 •
edited

What

Resolving #29744

How

limit backoff time to 10 seconds

Recommended reading order

  1. streams.py

馃毃 User Impact 馃毃

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@vercel
Copy link

vercel bot commented Oct 2, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs 猬滐笍 Ignored (Inspect) Visit Preview Oct 2, 2023 1:48pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/github labels Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023 •
edited by artem1205

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 馃帀

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205
Merge branch 'master' into artem1205/source-github-certification
fe889a8 
# Conflicts:
#	airbyte-integrations/connectors/source-github/Dockerfile
#	airbyte-integrations/connectors/source-github/metadata.yaml
#	docs/integrations/sources/github.md
@artem1205 artem1205 changed the title Artem1205/source GitHub certification Source GitHub: limit backoff time to 10 seconds Oct 2, 2023
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Oct 2, 2023
@artem1205 artem1205 changed the title Source GitHub: limit backoff time to 10 seconds Source GitHub: limit backoff time to 10 minutes Oct 23, 2023
@artem1205 artem1205 closed this Nov 1, 2023
@artem1205 artem1205 deleted the artem1205/source-github-certification branch November 16, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/github
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@artem1205 @octavia-squidington-iii