New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Github: marked start date as optional field #30971
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
source-github test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-github docker image for platform linux/x86_64 | ✅ |
Unit tests | ❌ |
Code format checks | ✅ |
Validate metadata for source-github | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-github test
source-github test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-github docker image for platform linux/x86_64 | ✅ |
Unit tests | ❌ |
Code format checks | ✅ |
Validate metadata for source-github | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-github test
source-github test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-github docker image for platform linux/x86_64 | ✅ |
Unit tests | ❌ |
Code format checks | ✅ |
Validate metadata for source-github | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-github test
source-github test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-github docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate metadata for source-github | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-github test
airbyte-integrations/connectors/source-github/unit_tests/test_source.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to cert requirements, we should sync all available data if start_date is not provided and is not required.
it seems like we can ignore initial start date comparison (if we have no start_date) in semi-incremental streams: https://github.com/airbytehq/airbyte/blob/9e2b1db192ea3a0869fb8ca35f828347d48551b3/airbyte-integrations/connectors/source-github/source_github/streams.py#L296C28-L296C28
source-github test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-github docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate metadata for source-github | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-github test
source-github test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-github docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate metadata for source-github | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-github test
source-github test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-github docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate metadata for source-github | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-github test
Co-authored-by: darynaishchenko <darynaishchenko@users.noreply.github.com>
Co-authored-by: darynaishchenko <darynaishchenko@users.noreply.github.com>
What
Start date was a required, which is not suitable for certification.
How
Start date is optional, if start date is not set, all data will be replicated