-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Source Open Exchange Rates: Migrate Python CDK to Low-code CDK #30983
✨Source Open Exchange Rates: Migrate Python CDK to Low-code CDK #30983
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
config Open-temp-creds |
Ready for review comments please :) |
Thanks for the contribution @btkcodedev. I added it to the team backlog and we're planning to start next week the review process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a review to understand the breaking change.
backward_compatibility_tests_config: | ||
disable_for_version: 0.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the previous version isn't backward compatible you need to release a major version, change to 1.0.0 as a breaking change. Why are you update the schema and specification of this connector?
What
Migrating Source Open Exchange Rates to Low-Code CDK
Closes #30906
How
Developed using (Configuration Based Source) low-code CDK
Recommended reading order
spec.yaml
manifest.yaml
schemas/*
Tests
Integration & Acceptance
Full Test Results ![image](https://github.com/airbytehq/airbyte/assets/47392334/ebffaa80-2ab7-40ed-b675-2db4e781a24d)🚨 User Impact 🚨
Migrate Connector: Source Open Exchange Rates
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md