Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Source Wrike: Migrate Python CDK to Low-code CDK #31058

Merged
merged 12 commits into from Oct 24, 2023
Merged

✨Source Wrike: Migrate Python CDK to Low-code CDK #31058

merged 12 commits into from Oct 24, 2023

Conversation

btkcodedev
Copy link
Collaborator

@btkcodedev btkcodedev commented Oct 4, 2023 •
edited

What

Migrating Source Wrike to Low-Code CDK
Closes #30885

How

Developed using (Configuration Based Source) low-code CDK

Recommended reading order

  1. spec.yaml
  2. manifest.yaml
  3. schemas/*

Tests

Integration & Acceptance Full Test Results

image

🚨 User Impact 🚨

  • No breaking changes, migration to low-code
Migrate Connector: Source Wrike

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

@vercel
Copy link

vercel bot commented Oct 4, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 1:18pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/wrike labels Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@btkcodedev btkcodedev mentioned this pull request Oct 4, 2023
Closed
@btkcodedev
Copy link
Collaborator Author

Test results: Full pass state
image

@btkcodedev
Copy link
Collaborator Author

Ping via slack for credentials: Slack ID: btkcodedev

@marcosmarxm
Copy link
Member

Thanks for the contribution 🚀 . I added it to the team backlog and we're planning to start next week the review process.

@sajarin sajarin self-assigned this Oct 9, 2023
@marcosmarxm marcosmarxm added the low-code-migration This connector has been migrated to the low-code CDK label Oct 9, 2023
marcosmarxm
marcosmarxm requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a quick review asking to update a few files this will help us during the code review. Sorry the long delay to get into your contribution. Probably this week or next one the team will start the process. Are you able to run the tests in your local setup? It can speed up a lot the process if you share the integration tests results

airbyte-integrations/connectors/source-wrike/build.gradle Outdated
Comment on lines 1 to 8
plugins {
id 'airbyte-python'
id 'airbyte-docker'
}

airbytePython {
moduleDirectory 'source_wrike'
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this isn't used anymore.

airbyte-integrations/connectors/source-wrike/integration_tests/abnormal_state.json Outdated
Comment on lines 1 to 5
{
"todo-stream-name": {
"todo-field-name": "todo-abnormal-value"
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this file.

airbyte-integrations/connectors/source-wrike/requirements.txt Outdated
@@ -1 +1,2 @@
-e ../../bases/connector-acceptance-test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this not used anymore.

airbyte-integrations/connectors/source-wrike/setup.py Outdated
"pytest-mock~=3.6.1",
"connector-acceptance-test",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this not used anymore.

marcosmarxm
marcosmarxm approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @btkcodedev

@marcosmarxm marcosmarxm merged commit 2bbfb51 into airbytehq:master Oct 24, 2023
39 of 48 checks passed
@marcosmarxm marcosmarxm self-assigned this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees

@marcosmarxm marcosmarxm

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/wrike hackathon-2023-10 low-code-migration This connector has been migrated to the low-code CDK
Projects
Community Contributed PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Source Wrike : Migrate Python CDK to Low-code CDK
4 participants
@btkcodedev @marcosmarxm @sajarin @octavia-squidington-iii