Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "T&D: Use non-null columns for PKs rather then scanning raw ta… #31082

Merged
merged 3 commits into from Oct 4, 2023

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Oct 4, 2023

No description provided.

…ble to ensure all records have PKs (#30779)"

This reverts commit 4992fce.
@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2023 10:02pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@edgao edgao marked this pull request as ready for review October 4, 2023 22:00
@edgao edgao requested a review from a team as a code owner October 4, 2023 22:00
@edgao edgao enabled auto-merge (squash) October 4, 2023 22:01
@airbyte-oss-build-runner
Copy link
Collaborator

destination-bigquery test report (commit 9cbaad1b51) - ✅

⏲️ Total pipeline duration: 08mn40s

Step Result
Build connector tar
Build destination-bigquery docker image for platform(s) linux/x86_64
Java Connector Unit Tests
Java Connector Integration Tests
Validate metadata for destination-bigquery
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-snowflake test report (commit 9cbaad1b51) - ✅

⏲️ Total pipeline duration: 10mn53s

Step Result
Build connector tar
Build destination-snowflake docker image for platform(s) linux/x86_64
Java Connector Unit Tests
Java Connector Integration Tests
Validate metadata for destination-snowflake
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test

@edgao
Copy link
Contributor Author

edgao commented Oct 4, 2023

/approve-and-merging reason="gradle check failure is from source-postgres"

@edgao
Copy link
Contributor Author

edgao commented Oct 4, 2023

/approve-and-merge reason="gradle check failure is from source-postgres"

@octavia-approvington
Copy link
Contributor

After a careful ML study,
we think this looks okay.
imagine code being okay

@octavia-approvington octavia-approvington merged commit ad5ce75 into master Oct 4, 2023
21 of 25 checks passed
@octavia-approvington octavia-approvington deleted the edgao/pin branch October 4, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants