Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source MongoDB: add supporting TLS and Replica Sets #3111

Merged
merged 4 commits into from
Apr 30, 2021
Merged

Source MongoDB: add supporting TLS and Replica Sets #3111

merged 4 commits into from
Apr 30, 2021

Conversation

yevhenii-ldv
Copy link
Contributor

What

closes #2420 and #2421.

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

Recommended reading order

  1. test.java
  2. component.ts
  3. the rest

@yevhenii-ldv yevhenii-ldv requested review from sherifnada and removed request for michel-tricot and davinchia April 28, 2021 14:33
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Apr 28, 2021 •
edited by github-actions bot
Loading

/test connector=source-mongodb

🕑 source-mongodb https://github.com/airbytehq/airbyte/actions/runs/792994519
✅ source-mongodb https://github.com/airbytehq/airbyte/actions/runs/792994519

sherifnada
sherifnada approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great with one comment: is ssl really required? Can we assume it's false if not passed in?

@yevhenii-ldv yevhenii-ldv linked an issue Apr 28, 2021 that may be closed by this pull request
Source MongoDB: Support connecting to replicaSets #2421
Closed
sherifnada
sherifnada approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏼💪🏼💪🏼💪🏼

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Apr 30, 2021 •
edited by github-actions bot
Loading

/test connector=source-mongodb

🕑 source-mongodb https://github.com/airbytehq/airbyte/actions/runs/800467244
✅ source-mongodb https://github.com/airbytehq/airbyte/actions/runs/800467244

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Apr 30, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mongodb

🕑 connectors/source-mongodb https://github.com/airbytehq/airbyte/actions/runs/800498582
✅ connectors/source-mongodb https://github.com/airbytehq/airbyte/actions/runs/800498582

@yevhenii-ldv yevhenii-ldv merged commit 672ebb4 into master Apr 30, 2021
@yevhenii-ldv yevhenii-ldv deleted the ykurochkin/mongodb-support-tls-and-replicasets branch April 30, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source MongoDB: Support connecting to replicaSets Source MongoDB: Support TLS
2 participants
@yevhenii-ldv @sherifnada