Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Asana: Add new stream Portfolio Memberships #31110

Merged
merged 12 commits into from Nov 6, 2023

Conversation

btkcodedev
Copy link
Collaborator

What

Closes #16805

Enhancement

New streams:

  • Portfolio Memberships

Recommended reading order

  1. source_asana/configured_catalog.json
  2. source_asana/source.py
  3. source_asana/schemas/*

🚨 User Impact 🚨

No breaking changes

Pre-merge Checklist

Updating a connector

Community member or Airbyter [Yes]

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Documentation which references the generator is updated as needed

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 4:10pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/asana labels Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link
Contributor

@archangelic archangelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, this does not sync any data. This endpoint requires that a workspace or portfolio is passed in the query parameters in order to work. This functionality will need to be added.

@sajarin
Copy link
Contributor

sajarin commented Oct 24, 2023

@btkcodedev are you able to address the issue mentioned above here?

@btkcodedev
Copy link
Collaborator Author

@sajarin @archangelic Sorry for the delay,
I've added the parent stream for slices
Portfolio requires Workspace param ✅
Portfolio memberships require portfolio param ✅

Added both slices as parameters

@sajarin
Copy link
Contributor

sajarin commented Oct 25, 2023

@btkcodedev

  1. Can you rebase on master?
  2. Check this linked comment for the same error with the Portfolios stream (Owner value is required and missing, despite what the docs say)

@sajarin
Copy link
Contributor

sajarin commented Oct 27, 2023

@btkcodedev any update here?

@btkcodedev
Copy link
Collaborator Author

@sajarin I've added owner slice from project details stream
Hope it works.

@btkcodedev
Copy link
Collaborator Author

Also rebased to master, Its ready

@sajarin sajarin merged commit b799678 into airbytehq:master Nov 6, 2023
35 of 41 checks passed
girarda pushed a commit that referenced this pull request Nov 7, 2023
Co-authored-by: Sajarin <sajarindider@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Source Asana: new stream Portfolio Memberships
5 participants