🐛Source Airtable: wrap HTTPError 400 in AirbyteTracedException #31119

askarpets · 2023-10-06T08:23:49Z

What

Avoid raising HTTPError with code 400 on getting refresh_token operation

How

Raise AirbyteTracedException in case refresh_token response returned with status code of 400 and error type of invalid_grant

🚨 User Impact 🚨

No breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

vercel · 2023-10-06T08:23:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Oct 10, 2023 2:20pm

github-actions · 2023-10-06T08:24:10Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

airbyte-oss-build-runner · 2023-10-06T08:28:00Z

source-airtable test report (commit `1f042fb89b`) - ❌

⏲️ Total pipeline duration: 02mn04s

Step	Result
Connector package install	✅
Build source-airtable docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate metadata for source-airtable	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-airtable test

airbyte-oss-build-runner · 2023-10-06T11:10:12Z

source-airtable test report (commit `1f042fb89b`) - ❌

⏲️ Total pipeline duration: 01mn11s

Step	Result
Connector package install	✅
Build source-airtable docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate metadata for source-airtable	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-airtable test

darynaishchenko · 2023-10-06T11:20:43Z

airbyte-integrations/connectors/source-airtable/source_airtable/auth.py

+        if response.status_code == 400 and content.get("error") == "invalid_grant":
+            raise AirbyteTracedException(
+                internal_message=content.get("error_description"),
+                message="Refresh token is invalid. Please update it in the config.",


We need to provide understandable user messages, users click 'Authenticate' button in set up page, which doesn't show refresh token field. if we want to ask user create a new one we should ask him to 'Re-authenticate'.

Refresh token is invalid/expired. Please re-authenticate to restore access to Airtable. - more suitable error message.

Thanks for the advice, updated

roman-yermilov-gl

If version is increased then documentation should also be updated. Please update changelog section with your version/PR link/description info

airbyte-oss-build-runner · 2023-10-06T11:33:32Z

source-airtable test report (commit `c2dd9c5e6b`) - ❌

⏲️ Total pipeline duration: 02mn01s

Step	Result
Connector package install	✅
Build source-airtable docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate metadata for source-airtable	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-airtable test

# Conflicts: # airbyte-integrations/connectors/source-airtable/Dockerfile # airbyte-integrations/connectors/source-airtable/metadata.yaml # docs/integrations/sources/airtable.md

airbyte-oss-build-runner · 2023-10-10T11:26:41Z

source-airtable test report (commit `df9b9c792a`) - ❌

⏲️ Total pipeline duration: 02mn24s

Step	Result
Connector package install	✅
Build source-airtable docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate metadata for source-airtable	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-airtable test

airbyte-oss-build-runner · 2023-10-10T11:39:06Z

source-airtable test report (commit `df9b9c792a`) - ❌

⏲️ Total pipeline duration: 02mn08s

Step	Result
Connector package install	✅
Build source-airtable docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate metadata for source-airtable	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-airtable test

airbyte-oss-build-runner · 2023-10-10T12:10:54Z

source-airtable test report (commit `e70d4bd63e`) - ❌

⏲️ Total pipeline duration: 02mn05s

Step	Result
Connector package install	✅
Build source-airtable docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate metadata for source-airtable	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-airtable test

airbyte-oss-build-runner · 2023-10-10T14:22:58Z

source-airtable test report (commit `068d81a7eb`) - ✅

⏲️ Total pipeline duration: 01mn09s

Step	Result
Connector package install	✅
Build source-airtable docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-airtable	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-airtable test

…tehq#31119)

Source Airtable: wrap HTTPError 400 in AirbyteTracedException

1f042fb

octavia-squidington-iii added area/connectors Connector related issues connectors/source/airtable labels Oct 6, 2023

askarpets requested review from darynaishchenko and roman-yermilov-gl October 6, 2023 08:31

darynaishchenko requested changes Oct 6, 2023

View reviewed changes

roman-yermilov-gl suggested changes Oct 6, 2023

View reviewed changes

Update error message and changelog

c2dd9c5

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 6, 2023

vercel bot deployed to Preview October 6, 2023 11:31 View deployment

askarpets requested review from darynaishchenko and roman-yermilov-gl October 6, 2023 11:32

darynaishchenko approved these changes Oct 6, 2023

View reviewed changes

roman-yermilov-gl approved these changes Oct 6, 2023

View reviewed changes

askarpets requested a review from bnchrch October 9, 2023 07:00

bnchrch approved these changes Oct 9, 2023

View reviewed changes

Anton Karpets added 2 commits October 10, 2023 14:16

Merge branch 'master' into 25837-wrap-http-error

2e0dd81

# Conflicts: # airbyte-integrations/connectors/source-airtable/Dockerfile # airbyte-integrations/connectors/source-airtable/metadata.yaml # docs/integrations/sources/airtable.md

Update docker image version and changelog

df9b9c7

vercel bot deployed to Preview October 10, 2023 11:50 View deployment

Update expected records

e70d4bd

airbytehq deleted a comment from airbyte-oss-build-runner Oct 10, 2023

Ignore attachments links in expected_records

068d81a

askarpets merged commit eeed77d into master Oct 10, 2023
24 checks passed

askarpets deleted the 25837-wrap-http-error branch October 10, 2023 14:38

edgao pushed a commit that referenced this pull request Oct 11, 2023

🐛Source Airtable: wrap HTTPError 400 in AirbyteTracedException (#31119)

38ce41e

ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 20, 2023

🐛Source Airtable: wrap HTTPError 400 in AirbyteTracedException (airby…

5551935

…tehq#31119)

ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023

🐛Source Airtable: wrap HTTPError 400 in AirbyteTracedException (airby…

6c2dee1

…tehq#31119)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛Source Airtable: wrap HTTPError 400 in AirbyteTracedException #31119

🐛Source Airtable: wrap HTTPError 400 in AirbyteTracedException #31119

askarpets commented Oct 6, 2023

vercel bot commented Oct 6, 2023 •

edited

Loading

github-actions bot commented Oct 6, 2023 •

edited by askarpets

Loading

airbyte-oss-build-runner commented Oct 6, 2023

airbyte-oss-build-runner commented Oct 6, 2023

darynaishchenko Oct 6, 2023

askarpets Oct 6, 2023

roman-yermilov-gl left a comment

airbyte-oss-build-runner commented Oct 6, 2023

airbyte-oss-build-runner commented Oct 10, 2023

airbyte-oss-build-runner commented Oct 10, 2023

airbyte-oss-build-runner commented Oct 10, 2023

airbyte-oss-build-runner commented Oct 10, 2023

🐛Source Airtable: wrap HTTPError 400 in AirbyteTracedException #31119

🐛Source Airtable: wrap HTTPError 400 in AirbyteTracedException #31119

Conversation

askarpets commented Oct 6, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

vercel bot commented Oct 6, 2023 • edited Loading

github-actions bot commented Oct 6, 2023 • edited by askarpets Loading

Before Merging a Connector Pull Request

airbyte-oss-build-runner commented Oct 6, 2023

source-airtable test report (commit 1f042fb89b) - ❌

airbyte-oss-build-runner commented Oct 6, 2023

source-airtable test report (commit 1f042fb89b) - ❌

darynaishchenko Oct 6, 2023

Choose a reason for hiding this comment

askarpets Oct 6, 2023

Choose a reason for hiding this comment

roman-yermilov-gl left a comment

Choose a reason for hiding this comment

airbyte-oss-build-runner commented Oct 6, 2023

source-airtable test report (commit c2dd9c5e6b) - ❌

airbyte-oss-build-runner commented Oct 10, 2023

source-airtable test report (commit df9b9c792a) - ❌

airbyte-oss-build-runner commented Oct 10, 2023

source-airtable test report (commit df9b9c792a) - ❌

airbyte-oss-build-runner commented Oct 10, 2023

source-airtable test report (commit e70d4bd63e) - ❌

airbyte-oss-build-runner commented Oct 10, 2023

source-airtable test report (commit 068d81a7eb) - ✅

vercel bot commented Oct 6, 2023 •

edited

Loading

github-actions bot commented Oct 6, 2023 •

edited by askarpets

Loading

source-airtable test report (commit `1f042fb89b`) - ❌

source-airtable test report (commit `1f042fb89b`) - ❌

source-airtable test report (commit `c2dd9c5e6b`) - ❌

source-airtable test report (commit `df9b9c792a`) - ❌

source-airtable test report (commit `df9b9c792a`) - ❌

source-airtable test report (commit `e70d4bd63e`) - ❌

source-airtable test report (commit `068d81a7eb`) - ✅