Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: fix escaping bugs in with_integration_base_java_and_normalization #31133

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Oct 6, 2023

Recently we noticed something wrong when building destination-redshift; in the dagger logs:

1603: [2.60s] + pip3 install Cython pyyaml~=5.4 --no-build-isolation
1603: [2.60s] sh: line 1: 3.0: No such file or directory
1603: exec sh -c set -o xtrace && python -m ensurepip --upgrade && pip3 install Cython<3.0 pyyaml~=5.4 --no-build-isolation && pip3 install dbt-redshift==1.0.0 && pip3 install urllib3<2 ERROR: process "sh -c set -o xtrace && python -m ensurepip --upgrade && pip3 install Cython<3.0 pyyaml~=5.4 --no-build-isolation && pip3 install dbt-redshift==1.0.0 && pip3 install urllib3<2" did not complete successfully: exit code: 1

As it turns out, the sh_dash_c function doesn't escape characters properly. This wasn't known to cause any issues, until now. I've since added the missing ' because it turns out that alternative solutions like escaping using shlex have their own issues.

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 7:17pm

@postamar postamar changed the title airbyte-ci: fix escaping bugs in sh_dash_c [DNM] airbyte-ci: fix escaping bugs in sh_dash_c Oct 6, 2023
@postamar postamar changed the title [DNM] airbyte-ci: fix escaping bugs in sh_dash_c airbyte-ci: fix escaping bugs in with_integration_base_java_and_normalization Oct 6, 2023
@postamar postamar requested a review from a team October 6, 2023 18:05
@postamar postamar enabled auto-merge (squash) October 6, 2023 18:05
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Oct 6, 2023
@postamar
Copy link
Contributor Author

postamar commented Oct 6, 2023

This PR has another unrelated commit which fixes some failing test which prevented the CI from being green. Merge at your leisure.

Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Oct 6, 2023
@postamar postamar merged commit 2704638 into master Oct 6, 2023
21 checks passed
@postamar postamar deleted the postamar/fix-sh-dash-c branch October 6, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants