New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update slack to return empty iterable instead of a empty list #31134
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
@@ -137,6 +137,7 @@ It is recommended to sync required channels only, this can be done by specifying | |||
|
|||
| Version | Date | Pull Request | Subject | | |||
|:--------|:-----------|:---------------------------------------------------------|:------------------------------------------------------------------------------------| | |||
| 0.3.4 | 2023-10-06 | [31134](https://github.com/airbytehq/airbyte/pull/31134) | Update CDK and remove non iterable return from records | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 0.3.4 | 2023-10-06 | [31134](https://github.com/airbytehq/airbyte/pull/31134) | Update CDK and remove non iterable return from records | | |
| 0.3.4 | 2023-10-06 | [31134](https://github.com/airbytehq/airbyte/pull/31134) | Update CDK and remove no-interator return from records | |
.. I may have messed up the table with this suggestion so take it with a grain of salt lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I.... do not like this change.
But! I loved all the others 😛
airbyte-integrations/connectors/source-slack/source_slack/source.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
source-slack test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-slack docker image for platform(s) linux/x86_64 | ✅ |
Unit tests | ❌ |
Code format checks | ✅ |
Validate metadata for source-slack | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-slack test
source-slack test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-slack docker image for platform(s) linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate metadata for source-slack | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-slack test
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
What
Source Slack is failing with 'list' object is not an iterator
https://airbytehq.sentry.io/issues/4508254133/?alert_rule_id=11478402&alert_type=issue¬ification_uuid=1295203e-5b64-45d0-91d9-70b3377988a9&project=6527718
This seems to be related to Slack returning an empty list in one case
https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-slack/source_slack/source.py#L213
Related to: #31122
How
Weve already updated the cdk to handle this for all connectors.
This PR