Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slack to return empty iterable instead of a empty list #31134

Merged
merged 5 commits into from Oct 6, 2023

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented Oct 6, 2023

What

Source Slack is failing with 'list' object is not an iterator
https://airbytehq.sentry.io/issues/4508254133/?alert_rule_id=11478402&alert_type=issue&notification_uuid=1295203e-5b64-45d0-91d9-70b3377988a9&project=6527718

This seems to be related to Slack returning an empty list in one case
https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-slack/source_slack/source.py#L213

Related to: #31122

How

Weve already updated the cdk to handle this for all connectors.

This PR

  1. Updates the connector to use the new cdk
  2. casts the array iterable on the slack side to be safe

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 7:24pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@@ -137,6 +137,7 @@ It is recommended to sync required channels only, this can be done by specifying

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:------------------------------------------------------------------------------------|
| 0.3.4 | 2023-10-06 | [31134](https://github.com/airbytehq/airbyte/pull/31134) | Update CDK and remove non iterable return from records |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| 0.3.4 | 2023-10-06 | [31134](https://github.com/airbytehq/airbyte/pull/31134) | Update CDK and remove non iterable return from records |
| 0.3.4 | 2023-10-06 | [31134](https://github.com/airbytehq/airbyte/pull/31134) | Update CDK and remove no-interator return from records |

.. I may have messed up the table with this suggestion so take it with a grain of salt lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I.... do not like this change.

But! I loved all the others 😛

Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
@airbyte-oss-build-runner
Copy link
Collaborator

source-slack test report (commit f7238eb65c) - ❌

⏲️ Total pipeline duration: 31.13s

Step Result
Connector package install
Build source-slack docker image for platform(s) linux/x86_64
Unit tests
Code format checks
Validate metadata for source-slack
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-slack test

@airbyte-oss-build-runner
Copy link
Collaborator

source-slack test report (commit a5817fc75c) - ✅

⏲️ Total pipeline duration: 74mn52s

Step Result
Connector package install
Build source-slack docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-slack
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-slack test

@bnchrch bnchrch merged commit 914206f into master Oct 6, 2023
24 checks passed
@bnchrch bnchrch deleted the bnchrch/source-slack-empty-list branch October 6, 2023 21:40
edgao pushed a commit that referenced this pull request Oct 11, 2023
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants