-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove strict encrypt variant of db2 #31146
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why no metadata thou 🤷
|
Step | Result |
---|---|
Build connector tar | ✅ |
Build source-db2 docker image for platform(s) linux/x86_64 | ✅ |
Java Connector Unit Tests | ❌ |
Java Connector Integration Tests | ❌ |
Acceptance tests | ✅ |
Validate metadata for source-db2 | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-db2 test
|
Step | Result |
---|---|
Build connector tar | ✅ |
Build source-db2 docker image for platform(s) linux/x86_64 | ✅ |
Java Connector Unit Tests | ❌ |
Java Connector Integration Tests | ❌ |
Acceptance tests | ✅ |
Validate metadata for source-db2 | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-db2 test
|
Step | Result |
---|---|
Build connector tar | ✅ |
Build source-db2 docker image for platform(s) linux/x86_64 | ✅ |
Java Connector Unit Tests | ❌ |
Java Connector Integration Tests | ❌ |
Acceptance tests | ✅ |
Validate metadata for source-db2 | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-db2 test
/approve-and-merge reason="ql 100 connector already failing on master is failing for the same reasons here. strictly removing (internal only) functionality" |
Co-authored-by: erohmensing <erohmensing@users.noreply.github.com>
Co-authored-by: erohmensing <erohmensing@users.noreply.github.com>
The strict encrypt variant of db2 has never had any use in cloud. It has also already been hidden from cloud for a while (so users haven't been able to create new connections with it). We are deleting it. Bye!