Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove strict encrypt variant of db2 #31146

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Oct 6, 2023

The strict encrypt variant of db2 has never had any use in cloud. It has also already been hidden from cloud for a while (so users haven't been able to create new connections with it). We are deleting it. Bye!

@erohmensing erohmensing requested a review from a team October 6, 2023 21:58
@erohmensing erohmensing requested a review from a team as a code owner October 6, 2023 21:58
@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 9:39pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no metadata thou 🤷

@airbyte-oss-build-runner
Copy link
Collaborator

source-db2 test report (commit 5a948ba142) - ❌

⏲️ Total pipeline duration: 06mn04s

Step Result
Build connector tar
Build source-db2 docker image for platform(s) linux/x86_64
Java Connector Unit Tests
Java Connector Integration Tests
Acceptance tests
Validate metadata for source-db2
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-db2 test

@airbyte-oss-build-runner
Copy link
Collaborator

source-db2 test report (commit 6ac8ec43ce) - ❌

⏲️ Total pipeline duration: 05mn03s

Step Result
Build connector tar
Build source-db2 docker image for platform(s) linux/x86_64
Java Connector Unit Tests
Java Connector Integration Tests
Acceptance tests
Validate metadata for source-db2
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-db2 test

@airbyte-oss-build-runner
Copy link
Collaborator

source-db2 test report (commit 53352b9534) - ❌

⏲️ Total pipeline duration: 49mn03s

Step Result
Build connector tar
Build source-db2 docker image for platform(s) linux/x86_64
Java Connector Unit Tests
Java Connector Integration Tests
Acceptance tests
Validate metadata for source-db2
Connector version semver check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-db2 test

@erohmensing
Copy link
Contributor Author

/approve-and-merge reason="ql 100 connector already failing on master is failing for the same reasons here. strictly removing (internal only) functionality"

@octavia-approvington
Copy link
Contributor

A job well done
nice job

@octavia-approvington octavia-approvington merged commit 00579f2 into master Oct 19, 2023
21 of 23 checks passed
@octavia-approvington octavia-approvington deleted the ella/axe-db2-strict-encrypt branch October 19, 2023 19:03
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 20, 2023
Co-authored-by: erohmensing <erohmensing@users.noreply.github.com>
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
Co-authored-by: erohmensing <erohmensing@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants