-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source-pipedrive: Use custom record extractor to handle records with null data #31147
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-pipedrive docker image for platform(s) linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate metadata for source-pipedrive | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-pipedrive test
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-pipedrive docker image for platform(s) linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate metadata for source-pipedrive | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-pipedrive test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@girarda This is so very well done. Thank you
Im just going to create a prerelease to test this out |
prerelease action run: https://github.com/airbytehq/airbyte/actions/runs/6437084481 |
@girarda Could you please ETA when this will be merged? |
I'll make sure this is merged today @bazarnov |
What
Create a custom record extractor for the source-pipedrive. The custom logic is required because pipedrive sometimes returns records with a null
data
field. Example:How
This was previously handled in the python implementation, but the migration to low-code caused a regression. This was implemented as
record = record.get(self.data_field) or record
.This PR adds a custom record extractor that applies the same logic we used to do.
Recommended reading order
airbyte-integrations/connectors/source-pipedrive/source_pipedrive/extractor.py
airbyte-integrations/connectors/source-pipedrive/unit_tests/test_extractor.py
airbyte-integrations/connectors/source-pipedrive/source_pipedrive/manifest.yaml
🚨 User Impact 🚨
The pipedrive connector syncs will properly handle records with a null data field
Pre-merge Actions
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.0.0.1
Dockerfile
has version0.0.1
README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog with an entry for the initial version. See changelog exampledocs/integrations/README.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Connector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:generateScaffolds
then checking in your changes