Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard Tests: hotfix - upgrade PyYAML #3123

Merged
merged 3 commits into from
Apr 28, 2021
Merged

Standard Tests: hotfix - upgrade PyYAML #3123

merged 3 commits into from
Apr 28, 2021

Conversation

keu
Copy link
Contributor

@keu keu commented Apr 28, 2021

What

error from CI

 The conflict is caused by:
	     airbyte-protocol 0.0.0 depends on PyYAML==5.4
	     source-acceptance-test 0.0.0 depends on PyYAML==5.3.1
	 To fix this you could try to:
	 1. loosen the range of package versions you've specified
	 2. remove package versions to allow pip attempt to solve the dependency conflict

How

upgrade PyYAML to 5.4

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

Recommended reading order

  1. test.java
  2. component.ts
  3. the rest

sherifnada
sherifnada approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to run ./gradlew format

@keu keu merged commit 8b1ac13 into master Apr 28, 2021
@keu keu deleted the keu/acceptance-tests-upgrade-yaml branch April 28, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@ChristopheDuong ChristopheDuong Awaiting requested review from ChristopheDuong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keu @sherifnada @eugene-kulak