-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation Reorganization #3124
Conversation
Preview the changes here: https://docs.airbyte.io/v/abhi%2Frestructuring/ |
This is great! |
Agree with your point about the contribution tutorials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @avaidyanatha! I like the breaking out into Quickstart
, Tutorials
and Example Use Cases
. I added a change that stop us from auto-generating some docs and should help the build pass.
From me:
- Can we change the
Reference
term? I usually associate references with specification-style documentation more focused on listing out the class + methods instead of what we have which is more along guides/conceptual docs explaining what is happening. What about a catch-all like 'Understanding Airbyte'? What do you think? - Project Overview seems strange to me as we already have an Introduction section, especially since it's at the bottom of our left nav bar. What about just breaking all those sections out into the top level nav bar? Would the nav bar be too cluttered?
Non-blocking since this is strictly better than our current state.
One question before I approve - how were the changes made? Was it by Gitbook? Asking since we had Gitbook do some weird formatting stuff in the past. If it is I'll give this a closer look over before approving just in case something funky happened.
Thank you @davinchia, really appreciate it! Also... thank you so much for fixing the autogenerated docs, was wondering why the build failed.
I can get on board with that for the Architecture section, as that fits really nicely under a "Understanding Airbyte" or "Concepts" section. For the API docs though, those are more strictly reference from my understanding.
We link to a lot of these pages directly (Roadmap, Changelog, Careers) from the website, GH repo, and introduction section, which is why I wanted to declutter by keeping them in their own section. Maybe it needs a different name?
I made all the changes manually in my IDE, so as far as I know, we shouldn't have any issues with that! |
@avaidyanatha happy to help!
What about puttling the API references to the top level as a standalone page for now and bringing all the remaining documents up one level and renaming the section to 'Understanding Airbyte'.
Hmm good point. What about getting rid of license/changelog/roadmap and promoting the career page to the top level? Willing to bet money most people actually scroll through all of the introduction as it's pretty short and will have seen those sections/know where to find the info. Putting careers up also helps with people interested with working with us. Cool. Manual edits should be great. Approving for now, please consider my comments as food for thought rather than required changes. |
@@ -99,18 +99,6 @@ task generateApiDocs(type: GenerateTask) { | |||
generatePom : "false", | |||
interfaceOnly: "true" | |||
] | |||
|
|||
doLast { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this removed instead of just changing the target, which would fix the build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just changed the path instead. Now it should still auto-update docs instead of keeping a stale copy.
Solid idea, done.
I left Project Overview in for now (we can think of a better name later) and moved Careers up to the top level for visibility. |
Main Inspiration
The documentation experience doesn't progress naturally and the "Tutorials" section is currently a catch-all for lots of different types of content. There's a lot that can be improved with the structure, so this is a first pass at that.
Main Changes
Misc Changes
Notes/Self-Feedback