New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Facebook Marketing: do not request funding_source_details if api raises an error #31284
🐛 Source Facebook Marketing: do not request funding_source_details if api raises an error #31284
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
source-facebook-marketing test report (commit
|
Step | Result |
---|---|
Build source-facebook-marketing docker image for platform(s) linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate metadata for source-facebook-marketing | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
… api raises an error (airbytehq#31284) Co-authored-by: davydov-d <davydov-d@users.noreply.github.com>
… api raises an error (airbytehq#31284) Co-authored-by: davydov-d <davydov-d@users.noreply.github.com>
What
FB API raises an error in rare and random cases when the connector tries to access the
funding_source_details
field of theAdAccount
stream.https://github.com/airbytehq/oncall/issues/3031
How
Retry the request without this field if the API raises an error
🚨 User Impact 🚨
Not a breaking change