Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector DBs: Upgrade CDK #31329

Merged
merged 24 commits into from Oct 18, 2023

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Oct 12, 2023

What

Two important bits:

Side note:

  • Use create_from_config to simplify embedder instance generation

How to test

How to run with LocalAI:

  • git clone https://github.com/go-skynet/LocalAI
  • cd LocalAI
  • wget https://huggingface.co/skeskinen/ggml/resolve/main/all-MiniLM-L6-v2/ggml-model-q4_0.bin -O models/bert
  • Save as models/embeddings.yml:
name: text-embedding-ada-002
parameters:
  model: bert
threads: 14
backend: bert-embeddings
embeddings: true
  • docker-compose up -d --pull always

Then configure the destination:

  • Base URL is http://host.docker.internal:8080
  • Embedding dimensions are 384

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 1:17pm

@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@flash1293 flash1293 changed the title Vector DBs: Add OpenAI-compatible embedding Vector DBs: Upgrade CDK Oct 12, 2023
Joe Reuter added 3 commits October 13, 2023 09:25
…ithub.com:airbytehq/airbyte into flash1293/allow-openai-compatible-embedding-modes
@airbyte-oss-build-runner
Copy link
Collaborator

destination-pinecone test report (commit 3992e5852e) - ✅

⏲️ Total pipeline duration: 02mn23s

Step Result
Build destination-pinecone docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for destination-pinecone
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-pinecone test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-weaviate test report (commit 3992e5852e) - ❌

⏲️ Total pipeline duration: 03mn33s

Step Result
Build destination-weaviate docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for destination-weaviate
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-weaviate test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-milvus test report (commit 3992e5852e) - ✅

⏲️ Total pipeline duration: 03mn36s

Step Result
Build destination-milvus docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for destination-milvus
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-milvus test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-qdrant test report (commit 0abba13335) - ✅

⏲️ Total pipeline duration: 01mn33s

Step Result
Build destination-qdrant docker image for platform(s) linux/x86_64
Unit tests
Code format checks
Validate metadata for destination-qdrant
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-qdrant test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-milvus test report (commit 0abba13335) - ❌

⏲️ Total pipeline duration: 03mn39s

Step Result
Build destination-milvus docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for destination-milvus
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-milvus test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-weaviate test report (commit 0abba13335) - ❌

⏲️ Total pipeline duration: 03mn39s

Step Result
Build destination-weaviate docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for destination-weaviate
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-weaviate test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-pinecone test report (commit 0abba13335) - ✅

⏲️ Total pipeline duration: 03mn38s

Step Result
Build destination-pinecone docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for destination-pinecone
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-pinecone test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-chroma test report (commit 0abba13335) - ✅

⏲️ Total pipeline duration: 03mn42s

Step Result
Build destination-chroma docker image for platform(s) linux/x86_64
Unit tests
Code format checks
Validate metadata for destination-chroma
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-chroma test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-qdrant test report (commit d1cfdf6799) - ❌

⏲️ Total pipeline duration: 44.82s

Step Result
Build destination-qdrant docker image for platform(s) linux/x86_64
Unit tests
Code format checks
Validate metadata for destination-qdrant
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-qdrant test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-chroma test report (commit d1cfdf6799) - ✅

⏲️ Total pipeline duration: 01mn02s

Step Result
Build destination-chroma docker image for platform(s) linux/x86_64
Unit tests
Code format checks
Validate metadata for destination-chroma
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-chroma test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-pinecone test report (commit d1cfdf6799) - ❌

⏲️ Total pipeline duration: 01mn31s

Step Result
Build destination-pinecone docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for destination-pinecone
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-pinecone test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-milvus test report (commit d1cfdf6799) - ✅

⏲️ Total pipeline duration: 01mn32s

Step Result
Build destination-milvus docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for destination-milvus
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-milvus test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-weaviate test report (commit d1cfdf6799) - ❌

⏲️ Total pipeline duration: 01mn31s

Step Result
Build destination-weaviate docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for destination-weaviate
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-weaviate test

Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice set of improvements and cleanup with the version bump. 👍
LGTM! 🚢

Comment on lines +34 to +38
self.embedder = (
create_from_config(config.embedding, config.processing)
if config.embedding.mode != "no_embedding"
else NoEmbedder(config.embedding)
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this logic be added into the create_from_config() decision matrix? Not a blocker, just want to get your thoughts.

@airbyte-oss-build-runner
Copy link
Collaborator

destination-qdrant test report (commit d6de473658) - ✅

⏲️ Total pipeline duration: 01mn09s

Step Result
Build destination-qdrant docker image for platform(s) linux/x86_64
Unit tests
Code format checks
Validate metadata for destination-qdrant
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-qdrant test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-pinecone test report (commit d6de473658) - ✅

⏲️ Total pipeline duration: 02mn32s

Step Result
Build destination-pinecone docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for destination-pinecone
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-pinecone test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-weaviate test report (commit d6de473658) - ✅

⏲️ Total pipeline duration: 02mn35s

Step Result
Build destination-weaviate docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for destination-weaviate
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-weaviate test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-milvus test report (commit d6de473658) - ✅

⏲️ Total pipeline duration: 02mn39s

Step Result
Build destination-milvus docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for destination-milvus
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-milvus test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-chroma test report (commit d6de473658) - ✅

⏲️ Total pipeline duration: 02mn55s

Step Result
Build destination-chroma docker image for platform(s) linux/x86_64
Unit tests
Code format checks
Validate metadata for destination-chroma
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-chroma test

@flash1293 flash1293 merged commit 083fc20 into master Oct 18, 2023
25 of 26 checks passed
@flash1293 flash1293 deleted the flash1293/allow-openai-compatible-embedding-modes branch October 18, 2023 13:48
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 20, 2023
Co-authored-by: flash1293 <flash1293@users.noreply.github.com>
Co-authored-by: alafanechere <augustin.lafanechere@gmail.com>
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
Co-authored-by: flash1293 <flash1293@users.noreply.github.com>
Co-authored-by: alafanechere <augustin.lafanechere@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants