Handle special characters in columns names #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
approved these changes
Apr 29, 2021
|
/test connector=bases/base-normalization
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #3128
How
JsonPath expressions can use the dot–notation
$.store.book[0].titleor the bracket–notation
$['store']['book'][0]['title']jsonpath specs
It seems the second option is more tolerant to special characters on BQ.
Tweak integration tests to include a column with special characters
Pre-merge Checklist
Recommended reading order
airbyte-integrations/bases/base-normalization/dbt-project-template/macros/cross_db_utils/json_operations.sql