Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: bind integration tests to dockerhost (again) #31343

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Oct 12, 2023

What

Some python connector integration test use docker (like source-file). We mistakenly removed the binding of integration tests to a dockerhost in #30474

How

Bind the Pytest integration test to a docker host service.

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 12, 2023 6:02pm

Copy link
Contributor Author

alafanechere commented Oct 12, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@alafanechere alafanechere marked this pull request as ready for review October 12, 2023 14:23
@alafanechere alafanechere requested a review from a team October 12, 2023 14:23
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 default is maintained.

@alafanechere alafanechere force-pushed the augustin/10-12-airbyte-ci_bind_integration_tests_to_dockerhost_again_ branch from 2ce6bd1 to 0ebdaf3 Compare October 12, 2023 18:00
@alafanechere alafanechere enabled auto-merge (squash) October 12, 2023 18:10
@alafanechere alafanechere merged commit 314e683 into master Oct 12, 2023
20 checks passed
@alafanechere alafanechere deleted the augustin/10-12-airbyte-ci_bind_integration_tests_to_dockerhost_again_ branch October 12, 2023 18:26
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 20, 2023
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants