Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source GitHub: handle ContributorActivity continuous ACCEPTED response #31386

Merged
merged 3 commits into from Oct 13, 2023

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Oct 13, 2023

What

Resolving #29744

Resolve https://github.com/airbytehq/oncall/issues/3059

How

update inapp version to align with standard docs
handle ContributorActivity continuous ACCEPTED response

Recommended reading order

  1. streams.py
  2. github.inapp.md

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@vercel
Copy link

vercel bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 2:49pm

@artem1205 artem1205 marked this pull request as ready for review October 13, 2023 13:07
@airbyte-oss-build-runner
Copy link
Collaborator

source-github test report (commit 7414ce4f88) - ❌

⏲️ Total pipeline duration: 06mn08s

Step Result
Build source-github docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-github
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-github test

@artem1205 artem1205 changed the title Source GitHub: update inapp docs Source GitHub: handle ContributorActivity continuous ACCEPTED response Oct 13, 2023
@artem1205 artem1205 self-assigned this Oct 13, 2023
@airbyte-oss-build-runner
Copy link
Collaborator

source-github test report (commit b64fde176c) - ✅

⏲️ Total pipeline duration: 09mn59s

Step Result
Build source-github docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-github
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-github test

@artem1205 artem1205 merged commit c7d4110 into master Oct 13, 2023
25 of 26 checks passed
@artem1205 artem1205 deleted the artem1205/source-github-update-inapp-docs branch October 13, 2023 16:35
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 20, 2023
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants