Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source LinkedIn Ads: fix pagination for reporting #31396

Merged
merged 4 commits into from Oct 13, 2023
Merged

Source LinkedIn Ads: fix pagination for reporting #31396

merged 4 commits into from Oct 13, 2023

Conversation

roman-yermilov-gl
Copy link
Collaborator

@roman-yermilov-gl roman-yermilov-gl commented Oct 13, 2023 •
edited

What

oncall https://github.com/airbytehq/oncall/issues/3264

How

Fix pagination (reporting does not support pagination)

  • records limit increased to 15000
  • next_page_token return None

@vercel
Copy link

vercel bot commented Oct 13, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 4:52pm

@roman-yermilov-gl roman-yermilov-gl self-assigned this Oct 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited by roman-yermilov-gl

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 13, 2023
@roman-yermilov-gl roman-yermilov-gl marked this pull request as ready for review October 13, 2023 16:21
bazarnov
bazarnov reviewed Oct 13, 2023
View reviewed changes
airbyte-integrations/connectors/source-linkedin-ads/source_linkedin_ads/streams.py Outdated
parsed_response = response.json()
if len(parsed_response.get("elements")) < self.records_limit:
return None
raise Exception("Limit 15000 elements exceeded. Try to request your data in more granular pieces.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f"Limit {self.record_limit}...."

airbyte-integrations/connectors/source-linkedin-ads/source_linkedin_ads/streams.py Outdated
parsed_response = response.json()
if len(parsed_response.get("elements")) < self.records_limit:
return None
raise Exception("Limit 15000 elements exceeded. Try to request your data in more granular pieces.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How the customer could achieve this?

@airbyte-oss-build-runner
Copy link
Collaborator

source-linkedin-ads test report (commit 823b36b8b5) - ✅

⏲️ Total pipeline duration: 10mn37s

Step Result
Build source-linkedin-ads docker image for platform(s) linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅
Code format checks ✅
Validate metadata for source-linkedin-ads ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linkedin-ads test

@airbyte-oss-build-runner
Copy link
Collaborator

source-linkedin-ads test report (commit bfda5e984b) - ✅

⏲️ Total pipeline duration: 09mn58s

Step Result
Build source-linkedin-ads docker image for platform(s) linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅
Code format checks ✅
Validate metadata for source-linkedin-ads ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linkedin-ads test

@airbyte-oss-build-runner
Copy link
Collaborator

source-linkedin-ads test report (commit b762eb494e) - ✅

⏲️ Total pipeline duration: 09mn01s

Step Result
Build source-linkedin-ads docker image for platform(s) linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅
Code format checks ✅
Validate metadata for source-linkedin-ads ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linkedin-ads test

@roman-yermilov-gl roman-yermilov-gl merged commit 2e7dfe8 into master Oct 13, 2023
23 of 24 checks passed
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-linkedin-ads-fix-pagination-for-reports branch October 13, 2023 19:43
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 20, 2023
@roman-yermilov-gl @ariesgun
Source LinkedIn Ads: fix pagination for reporting (airbytehq#31396)
47867a6
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
@roman-yermilov-gl @ariesgun
Source LinkedIn Ads: fix pagination for reporting (airbytehq#31396)
e8d6c3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazarnov bazarnov bazarnov approved these changes

@artem1205 artem1205 Awaiting requested review from artem1205

@darynaishchenko darynaishchenko Awaiting requested review from darynaishchenko

@lazebnyi lazebnyi Awaiting requested review from lazebnyi

Assignees

@roman-yermilov-gl roman-yermilov-gl

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/linkedin-ads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roman-yermilov-gl @airbyte-oss-build-runner @bazarnov @octavia-squidington-iii