Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: remove connector format command #31424

Merged

Conversation

alafanechere
Copy link
Contributor

What

Remove connector specific format command now that we want to implement a repo wide formatting command.

How

Delete the format command and related Step / pipelines

@vercel
Copy link

vercel bot commented Oct 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2023 3:52pm

Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@alafanechere alafanechere force-pushed the augustin/10-14-airbyte-ci_remove_connector_format_command branch from a228c1f to e79b520 Compare October 14, 2023 13:19
@alafanechere alafanechere requested a review from a team October 14, 2023 13:19
@alafanechere alafanechere enabled auto-merge (squash) October 14, 2023 13:37
@alafanechere alafanechere force-pushed the augustin/10-14-airbyte-ci_remove_connector_format_command branch from e79b520 to 4c49424 Compare October 16, 2023 16:55
Comment on lines 24 to 27
<<<<<<< HEAD
from pipelines.format import run_connector_format_pipeline
=======
>>>>>>> e79b52032d5 (airbyte-ci: remove connector format command)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflict :D

@alafanechere alafanechere force-pushed the augustin/10-14-airbyte-ci_remove_connector_format_command branch 2 times, most recently from 246fd78 to d978ec7 Compare October 17, 2023 08:57
@alafanechere alafanechere force-pushed the augustin/10-14-airbyte-ci_remove_connector_format_command branch from d978ec7 to a620d58 Compare October 17, 2023 15:51
@alafanechere alafanechere merged commit 7465c02 into master Oct 17, 2023
20 checks passed
@alafanechere alafanechere deleted the augustin/10-14-airbyte-ci_remove_connector_format_command branch October 17, 2023 17:00
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 20, 2023
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants