-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: remove connector format command #31424
Merged
alafanechere
merged 1 commit into
master
from
augustin/10-14-airbyte-ci_remove_connector_format_command
Oct 17, 2023
Merged
airbyte-ci: remove connector format command #31424
alafanechere
merged 1 commit into
master
from
augustin/10-14-airbyte-ci_remove_connector_format_command
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
alafanechere
force-pushed
the
augustin/10-14-airbyte-ci_remove_connector_format_command
branch
from
October 14, 2023 13:19
a228c1f
to
e79b520
Compare
alafanechere
force-pushed
the
augustin/10-14-airbyte-ci_remove_connector_format_command
branch
from
October 16, 2023 16:55
e79b520
to
4c49424
Compare
evantahler
requested changes
Oct 16, 2023
Comment on lines
24
to
27
<<<<<<< HEAD | ||
from pipelines.format import run_connector_format_pipeline | ||
======= | ||
>>>>>>> e79b52032d5 (airbyte-ci: remove connector format command) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge conflict :D
alafanechere
force-pushed
the
augustin/10-14-airbyte-ci_remove_connector_format_command
branch
2 times, most recently
from
October 17, 2023 08:57
246fd78
to
d978ec7
Compare
alafanechere
force-pushed
the
augustin/10-14-airbyte-ci_remove_connector_format_command
branch
from
October 17, 2023 15:51
d978ec7
to
a620d58
Compare
evantahler
approved these changes
Oct 17, 2023
alafanechere
deleted the
augustin/10-14-airbyte-ci_remove_connector_format_command
branch
October 17, 2023 17:00
ariesgun
pushed a commit
to ariesgun/airbyte
that referenced
this pull request
Oct 20, 2023
ariesgun
pushed a commit
to ariesgun/airbyte
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove connector specific format command now that we want to implement a repo wide formatting command.
How
Delete the
format
command and related Step / pipelines