🐛 Source Bing Ads: remove primary key for the geographic performance reports

[davydov-d]

What

https://github.com/airbytehq/oncall/issues/3068
In version 1.0.0 there was an attempt to remove the primary key from the geographic performance reports.
It wasn't successful because I missed that the mixin the reports are inherited from declares it's own primary key 😢

How

Override the primary key with None, add unit tests

🚨 User Impact 🚨

Same as in the previous update - users will get rid of primary keys, will have more data and will need to reset the data + refresh the schemas

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 17, 2023 9:43am

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
• If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[airbyte-oss-build-runner]

source-bing-ads test report (commit 2fd11d2594) - ❌

⏲️ Total pipeline duration: 22mn49s

Step	Result
Build source-bing-ads docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate metadata for source-bing-ads	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

[airbyte-oss-build-runner]

source-bing-ads test report (commit be3905619e) - ❌

⏲️ Total pipeline duration: 22mn33s

Step	Result
Build source-bing-ads docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-bing-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

[airbyte-oss-build-runner]

source-bing-ads test report (commit 88aa84fdcf) - ✅

⏲️ Total pipeline duration: 11mn54s

Step	Result
Build source-bing-ads docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-bing-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

[brianjlai]

@davydov-d
The code changes look good to me. But one thing that strikes me as a little bit of a concern is that we're rapidly incrementing the major version from 0.2.3 -> 1.0.0 -> 2.0.0. Given the context I have from the past 2 PRs, this latest one feels more like a bug fix that came from 1.0.0. Is there a reason why you opted for this breaking change designation? Is it so that its more clear that users will need to refresh their schemas?

My concern here is that the customer in question saw a degraded behavior on their sync using 1.0.0. And I'm not sure we have a good use case where we want to retain this major version if its basically not functional. And if that were the case, a normal patch fix to 1.0.1 should hopefully ensure users don't use the version with the defect?

I temporarily marked this a Request changes just to make sure we're all aligned with the version bump before we ship this. I could be missing context on why the major bump is necessary and would like to know more

[davydov-d]

@davydov-d The code changes look good to me. But one thing that strikes me as a little bit of a concern is that we're rapidly incrementing the major version from 0.2.3 -> 1.0.0 -> 2.0.0. Given the context I have from the past 2 PRs, this latest one feels more like a bug fix that came from 1.0.0. Is there a reason why you opted for this breaking change designation? Is it so that its more clear that users will need to refresh their schemas?

My concern here is that the customer in question saw a degraded behavior on their sync using 1.0.0. And I'm not sure we have a good use case where we want to retain this major version if its basically not functional. And if that were the case, a normal patch fix to 1.0.1 should hopefully ensure users don't use the version with the defect?

I temporarily marked this a Request changes just to make sure we're all aligned with the version bump before we ship this. I could be missing context on why the major bump is necessary and would like to know more

@brianjlai yes, this is a bug fix for v1.0.0. And yes, I decided it should be a breaking change for users to refresh their schemas and reset the data.
On the other hand, I can not dispute that this change is non-funcitonal, thus changed the major version bump to a patch.

[airbyte-oss-build-runner]

source-bing-ads test report (commit 885c0ba874) - ✅

⏲️ Total pipeline duration: 24mn35s

Step	Result
Build source-bing-ads docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-bing-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

[brianjlai]

@davydov-d thanks for clarifying. I can see the reasoning behind going either way. But I think we're aligned on using the patch. Though it might be clearer in the short run with the breaking change, for customers that write in, we can tell them to reset. And in the long run its probably better for us not to have a major version that contains the regression in it. Especially for OSS users who can dictate the version being used.