Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Tiktok Marketing: apply minimum datetime restrictions #31445

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented Oct 16, 2023

What

https://github.com/airbytehq/oncall/issues/2808
Some APIs return error in response to requesting data older than 2012-01-01

How

  • Set the start date to 2012-01-01 in case it is older than that + log a warning; add unit test
  • Update schema and expected records to pass tests

🚨 User Impact 🚨

No impact

@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2023 8:09am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@airbyte-oss-build-runner
Copy link
Collaborator

source-tiktok-marketing test report (commit 9b7cade992) - ❌

⏲️ Total pipeline duration: 43.00s

Step Result
Build source-tiktok-marketing docker image for platform(s) linux/x86_64
Unit tests
Code format checks
Validate metadata for source-tiktok-marketing
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 16, 2023
@airbyte-oss-build-runner
Copy link
Collaborator

source-tiktok-marketing test report (commit 528d2c9cd0) - ❌

⏲️ Total pipeline duration: 47mn29s

Step Result
Build source-tiktok-marketing docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-tiktok-marketing
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@airbyte-oss-build-runner
Copy link
Collaborator

source-tiktok-marketing test report (commit 7fca0453e5) - ❌

⏲️ Total pipeline duration: 50mn13s

Step Result
Build source-tiktok-marketing docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-tiktok-marketing
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@airbyte-oss-build-runner
Copy link
Collaborator

source-tiktok-marketing test report (commit f62dbff079) - ❌

⏲️ Total pipeline duration: 48mn02s

Step Result
Build source-tiktok-marketing docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-tiktok-marketing
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@airbyte-oss-build-runner
Copy link
Collaborator

source-tiktok-marketing test report (commit a822ffd3a6) - ❌

⏲️ Total pipeline duration: 42mn54s

Step Result
Build source-tiktok-marketing docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-tiktok-marketing
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@airbyte-oss-build-runner
Copy link
Collaborator

source-tiktok-marketing test report (commit 0da6a447b5) - ✅

⏲️ Total pipeline duration: 42mn51s

Step Result
Build source-tiktok-marketing docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-tiktok-marketing
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@davydov-d davydov-d merged commit 852ee37 into master Oct 17, 2023
25 of 27 checks passed
@davydov-d davydov-d deleted the ddavydov/#2808-source-tiktok-marketing-apply-minimum-datetime-restrictions branch October 17, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/tiktok-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants