airbyte-ci: fix None docker creds #31455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
alafanechere
force-pushed
the
augustin/10-16-airbyte-ci_fix_None_docker_creds
branch
from
4c39638
to
fd379a0
Compare
evantahler
approved these changes
Oct 16, 2023
alafanechere
deleted the
augustin/10-16-airbyte-ci_fix_None_docker_creds
branch
sajarin
pushed a commit
to topefolorunso/airbyte
that referenced
this pull request
Oct 16, 2023
ariesgun
pushed a commit
to ariesgun/airbyte
that referenced
this pull request
Oct 20, 2023
ariesgun
pushed a commit
to ariesgun/airbyte
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix
dockerhub_usernameanddockerhub_passwordbeingNoneHow
Fix a the regression introduced by #30520 :
Adding optional
docker_hub_*attributes to theConnectorContextclass and callingsuperfrom thePublishContext(ConnectorContext)after setting these attribute onPublishContextled a a re-assignation of thedocker_hub_attributes toNone