fix running connector-ops package tests via airbyte-ci #31478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
pedroslopez
changed the title
pedroslopez
changed the title
bnchrch
approved these changes
Oct 16, 2023
pedroslopez
force-pushed
the
pedro/fix_airbyte_ci_tests
branch
from
74b02f1
to
6e0c579
Compare
evantahler
approved these changes
Oct 16, 2023
Merge activity
|
ariesgun
pushed a commit
to ariesgun/airbyte
that referenced
this pull request
Oct 20, 2023
<!-- Thanks for your contribution! Before you submit the pull request, I'd like to kindly remind you to take a moment and read through our guidelines to ensure that your contribution aligns with the type of contributions our project accepts. All the information you need can be found here: https://docs.airbyte.com/contributing-to-airbyte/ We truly appreciate your interest in contributing to Airbyte, and we're excited to see what you have to offer! If you have any questions or need any assistance, feel free to reach out in #contributions Slack channel. --> ## What `airbyte-ci` tests for `connector-ops` package are failing in CI - this PR fixes this. ## How 1. Fix issue with running git commands in the test: - Add `fetch-depth: 0` to pull all history - Set `ref` to the PR head to avoid a detached head and allow the commands to work correctly 2. Fix issue with files missing when running test: - Add `docs` and `.github` dirs to the mounted test container. These are required to validate that docs exist, and that required reviewers file is written, respectively.
ariesgun
pushed a commit
to ariesgun/airbyte
that referenced
this pull request
Oct 23, 2023
<!-- Thanks for your contribution! Before you submit the pull request, I'd like to kindly remind you to take a moment and read through our guidelines to ensure that your contribution aligns with the type of contributions our project accepts. All the information you need can be found here: https://docs.airbyte.com/contributing-to-airbyte/ We truly appreciate your interest in contributing to Airbyte, and we're excited to see what you have to offer! If you have any questions or need any assistance, feel free to reach out in #contributions Slack channel. --> ## What `airbyte-ci` tests for `connector-ops` package are failing in CI - this PR fixes this. ## How 1. Fix issue with running git commands in the test: - Add `fetch-depth: 0` to pull all history - Set `ref` to the PR head to avoid a detached head and allow the commands to work correctly 2. Fix issue with files missing when running test: - Add `docs` and `.github` dirs to the mounted test container. These are required to validate that docs exist, and that required reviewers file is written, respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
airbyte-citests forconnector-opspackage are failing in CI - this PR fixes this.How
fetch-depth: 0to pull all historyrefto the PR head to avoid a detached head and allow the commands to work correctlydocsand.githubdirs to the mounted test container. These are required to validate that docs exist, and that required reviewers file is written, respectively.