Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

naively merge all python base modules into one #3148

Merged
merged 2 commits into from
Apr 30, 2021
Merged

naively merge all python base modules into one #3148

merged 2 commits into from
Apr 30, 2021

Conversation

sherifnada
Copy link
Contributor

What

Merges all python modules into a single one. The following are the substitutions that will be necessary in any consumer:

airbyte_protocol --> airbyte_cdk.models
base_singer --> airbyte_cdk.singer 
base_python --> airbyte_cdk.base_python

These are just temporary for Davin to test PyPi publishing. I'm currently cleaning up/refactoring the package, which will require more involved substitutions.

@auto-assign auto-assign bot requested review from cgardens and jrhizor April 30, 2021 03:08
@sherifnada sherifnada requested review from davinchia and removed request for jrhizor and cgardens April 30, 2021 03:08
@davinchia davinchia merged commit e9287e7 into master Apr 30, 2021
@davinchia davinchia deleted the sherif/merge-python-packages branch April 30, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinchia davinchia Awaiting requested review from davinchia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sherifnada @davinchia