Airbyte-ci: Increase airbyte-ci start time from ~11s to 0.8s #31488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
bnchrch
force-pushed
the
bnchrch/ci/lazy-load
branch
from
7d3470e
to
64a4337
Compare
erohmensing
approved these changes
Oct 19, 2023
Comment on lines
+115
to
+121
| "build": "pipelines.airbyte_ci.connectors.build_image.commands.build", | ||
| "test": "pipelines.airbyte_ci.connectors.test.commands.test", | ||
| "list": "pipelines.airbyte_ci.connectors.list.commands.list", | ||
| "publish": "pipelines.airbyte_ci.connectors.publish.commands.publish", | ||
| "bump_version": "pipelines.airbyte_ci.connectors.bump_version.commands.bump_version", | ||
| "migrate_to_base_image": "pipelines.airbyte_ci.connectors.migrate_to_base_image.commands.migrate_to_base_image", | ||
| "upgrade_base_image": "pipelines.airbyte_ci.connectors.upgrade_base_image.commands.upgrade_base_image", |
There was a problem hiding this comment.
This makes me sad because its more things the IDE can't refactor for us 😥
There was a problem hiding this comment.
I know :(
This was a solution recommended by click itself so I went with it
Comment on lines
+15
to
+18
| # lazy_subcommands is a map of the form: | ||
| # | ||
| # {command-name} -> {module-name}.{command-object-name} | ||
| # |
There was a problem hiding this comment.
Should we give it a Optional[Dict[str, str]] type to help reinforce this?
Comment on lines
+39
to
+41
| # check the result to make debugging easier | ||
| if not isinstance(cmd_object, click.BaseCommand): | ||
| raise ValueError(f"Lazy loading of {import_path} failed by returning " "a non-command object") |
ariesgun
pushed a commit
to ariesgun/airbyte
that referenced
this pull request
Oct 20, 2023
…hq#31488) Co-authored-by: bnchrch <bnchrch@users.noreply.github.com>
ariesgun
pushed a commit
to ariesgun/airbyte
that referenced
this pull request
Oct 23, 2023
…hq#31488) Co-authored-by: bnchrch <bnchrch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Python loads the kitchen sink by default and Click (our ci library) loads the entire kitchen
Solution
Introduce a lazy loading group as recommended by Click to lazily load command groups to save start up time
Before
After
Notes for reviewer
The largest noticable speed improvement is
airbyte-ci --versionThe slowest still will be
airbyte-ci --helpas it needs to load all commands just as beforeand `airbyte-ci connector test should be about 3s-6s faster
closes #31253