Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source TikTok Marketing: add undeclared fields to Ads stream #31493

Merged

Conversation

darynaishchenko
Copy link
Collaborator

What

resolved: #28392
Add utm_params to ads schema

How

added fields to ads stream schema based on API docs

@darynaishchenko darynaishchenko self-assigned this Oct 17, 2023
@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 9:24am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@airbyte-oss-build-runner
Copy link
Collaborator

source-tiktok-marketing test report (commit fc9570a730) - ❌

⏲️ Total pipeline duration: 18mn53s

Step Result
Build source-tiktok-marketing docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-tiktok-marketing
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@airbyte-oss-build-runner
Copy link
Collaborator

source-tiktok-marketing test report (commit ab2499f79a) - ❌

⏲️ Total pipeline duration: 42mn14s

Step Result
Build source-tiktok-marketing docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-tiktok-marketing
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@airbyte-oss-build-runner
Copy link
Collaborator

source-tiktok-marketing test report (commit 9af0fc60ce) - ❌

⏲️ Total pipeline duration: 43mn32s

Step Result
Build source-tiktok-marketing docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-tiktok-marketing
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@airbyte-oss-build-runner
Copy link
Collaborator

source-tiktok-marketing test report (commit 3895efdb17) - ❌

⏲️ Total pipeline duration: 42mn30s

Step Result
Build source-tiktok-marketing docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-tiktok-marketing
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@airbyte-oss-build-runner
Copy link
Collaborator

source-tiktok-marketing test report (commit 91f62b510a) - ❌

⏲️ Total pipeline duration: 41mn50s

Step Result
Build source-tiktok-marketing docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-tiktok-marketing
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@airbyte-oss-build-runner
Copy link
Collaborator

source-tiktok-marketing test report (commit 8e7a96afb8) - ✅

⏲️ Total pipeline duration: 42mn55s

Step Result
Build source-tiktok-marketing docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-tiktok-marketing
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@darynaishchenko darynaishchenko merged commit c2a958d into master Oct 19, 2023
25 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-tiktok-marketing/ads-stream-fields branch October 19, 2023 10:34
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 20, 2023
…tehq#31493)

Co-authored-by: darynaishchenko <darynaishchenko@users.noreply.github.com>
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
…tehq#31493)

Co-authored-by: darynaishchenko <darynaishchenko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/tiktok-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source TikTok: - Add utm_params to ads schema
4 participants