Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Stripe: Adjusted Setup Attempts and extended Checkout Sessions stream schemas, fix expected records #31553

Merged
merged 3 commits into from Oct 19, 2023

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Oct 18, 2023

What

Based on this test:

Need to update expected records, fix the checkout_sessions, setup_attempts stream schemas

How

  • adjusted the [properties][payment_method][customer] in setup_attempts stream, according to the Stripe Docs - payment methods object
  • extended the setup_attempts stream schema with client_secret (link), ui_mode (link) fields, which were unexpected while running CAT
  • updated expected records.jsonl

🚨 User Impact 🚨

This is the semi-breaking change, touching only the setup attempts stream, which is not in the list of the suggested streams. Consider this as a minor update.

@bazarnov bazarnov self-assigned this Oct 18, 2023
@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 10:27am

@bazarnov bazarnov changed the title 🐛 Source Stripe: Adjusted Setup Attempts and extended Checkout Sessions stream schemas, fix expected records` 🐛 Source Stripe: Adjusted Setup Attempts and extended Checkout Sessions stream schemas, fix expected records Oct 18, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Oct 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@bazarnov bazarnov marked this pull request as ready for review October 18, 2023 11:49
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 18, 2023
@bazarnov bazarnov requested a review from a team October 18, 2023 11:49
@airbyte-oss-build-runner

This comment was marked as outdated.

@airbyte-oss-build-runner
Copy link
Collaborator

source-stripe test report (commit 6739191d7e) - ✅

⏲️ Total pipeline duration: 09mn14s

Step Result
Build source-stripe docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-stripe
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:! Out of curiosity, do we know why our seed data disappeared?

@bazarnov
Copy link
Collaborator Author

@Diana-Vait Maybe you know the answer for the question? @girarda I didn't find the reason.

@bazarnov bazarnov merged commit c6c15d6 into master Oct 19, 2023
25 of 26 checks passed
@bazarnov bazarnov deleted the baz/source-stripe/fix-schemas-and-expected-records branch October 19, 2023 20:09
@Diana-Vait
Copy link

@girarda I also don't have this information. My only guess is that our previous subscription was overdue, but I'm not shure.

ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 20, 2023
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/stripe
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

5 participants