New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Stripe: Adjusted Setup Attempts
and extended Checkout Sessions
stream schemas, fix expected records
#31553
🐛 Source Stripe: Adjusted Setup Attempts
and extended Checkout Sessions
stream schemas, fix expected records
#31553
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Setup Attempts
and extended Checkout Sessions
stream schemas, fix expected records
`Setup Attempts
and extended Checkout Sessions
stream schemas, fix expected records
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
This comment was marked as outdated.
This comment was marked as outdated.
airbyte-integrations/connectors/source-stripe/source_stripe/schemas/setup_attempts.json
Show resolved
Hide resolved
source-stripe test report (commit
|
Step | Result |
---|---|
Build source-stripe docker image for platform(s) linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate metadata for source-stripe | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-stripe test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
! Out of curiosity, do we know why our seed data disappeared?
@Diana-Vait Maybe you know the answer for the question? @girarda I didn't find the reason. |
@girarda I also don't have this information. My only guess is that our previous subscription was overdue, but I'm not shure. |
…sions` stream schemas, fix `expected records` (airbytehq#31553)
…sions` stream schemas, fix `expected records` (airbytehq#31553)
What
Based on this test:
Need to update
expected records
, fix thecheckout_sessions
,setup_attempts
stream schemasHow
[properties][payment_method][customer]
insetup_attempts
stream, according to the Stripe Docs - payment methods objectsetup_attempts
stream schema withclient_secret
(link),ui_mode
(link) fields, which wereunexpected
while running CATexpected records.jsonl
🚨 User Impact 🚨
This is the semi-breaking change, touching only the
setup attempts
stream, which is not in the list of thesuggested
streams. Consider this as a minor update.