-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CDK publishing setup. #3156
Conversation
…create-pypi-module
…irbyte into davinchia/create-pypi-module
@sherifnada finally done! one question: what's Airbyte email should I use to set up an Airbyte PyPi account? Should I set up a new email for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good % comments
airbyte-integrations/connectors/source-exchange-rates/Dockerfile
Outdated
Show resolved
Hide resolved
not sure if this is the right ticket, but please makes sure the package works before publishing to PyPI |
@keu yeap. The CDK is working right now. Thanks for checking. |
sorry, I think I didn't make my point clear there, right now CDK is working because we install it from monorepo,
|
@keu yeap I get you. I should also be clearer - I tested on the Agree with you on tests and package-stability. Right now, I've published to PyPi (and Test PyPi) only to demonstrate the publishing mechanism works since Github actions are tricky. It was also a sanity test to see if |
Created PyPi and Test PyPi accounts for us. Credentials are in Lastpass. Same password and user for both. Added to secrets. |
What
Allow us to publish CDK versions on PyPi via Github workflows.
This lets us:
Note, this will not work on this branch as Github only detects new workflows after they are checked into master, so I was forced to develop and test this from a fork. Browse this PR or this PR to see this command in action.
See an example published package here. This was published from my fork. I also published an initial
0.0.1
on actual PyPi to demonstrate how this works with an actual package.Added publishing instructions to the Release Document.
Pre-merge Checklist
How
mariamrf/py-package-publish-action@v1.1.0
action to build and publish the built package to PyPi/TestPyPidry-run=false
flag is passed in as part of the command e.g./publish-cdk dry-run=false
.Recommended reading order
setup.py
- read through to understand how the package is configured.publish-cdk-command.yml
- understand the publish commandslash-commands.yml
- understand how this is linked