🐛Source Klaviyo: add missing field #31562

askarpets · 2023-10-18T14:26:53Z

What

Add field archived to flows stream.

How

Add "archived": { "type": "boolean" }, to flows.json and update acceptance tests expected records.

🚨 User Impact 🚨

No breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

vercel · 2023-10-18T14:27:00Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 19, 2023 7:05am

github-actions · 2023-10-18T14:27:20Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

airbyte-oss-build-runner · 2023-10-18T14:31:26Z

source-klaviyo test report (commit `fd62eb6a8c`) - ❌

⏲️ Total pipeline duration: 02mn58s

Step	Result
Build source-klaviyo docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate metadata for source-klaviyo	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-klaviyo test

erohmensing

Please update the changelog in the connector docs.

Otherwise, fixing a missed field, adding tests, populating a test stream? Great, no notes 👌🏻

erohmensing · 2023-10-18T15:53:39Z

airbyte-integrations/connectors/source-klaviyo/acceptance-test-config.yml

-        empty_streams:
-          - name: flows
-            bypass_reason: "the 'trigger' object may mutate often"


Nice - love populating test streams!

erohmensing · 2023-10-18T16:07:14Z

airbyte-integrations/connectors/source-klaviyo/unit_tests/test_source.py

+    source = SourceKlaviyo()
+    config = {"api_key": "some_key", "start_date": pendulum.datetime(2020, 10, 10).isoformat()}
+    streams = source.streams(config)
+    expected_streams_number = 8


for good measure can we add an assertion that all of the stream names are unique?

Updated, thanks for the advice!

airbyte-oss-build-runner · 2023-10-19T07:08:55Z

source-klaviyo test report (commit `907cfda43e`) - ✅

⏲️ Total pipeline duration: 03mn22s

Step	Result
Build source-klaviyo docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-klaviyo	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-klaviyo test

Source Klaviyo: add missing field

fd62eb6

askarpets self-assigned this Oct 18, 2023

octavia-squidington-iii added connectors/source/klaviyo area/connectors Connector related issues labels Oct 18, 2023

octavia-squidington-iv requested review from a team October 18, 2023 14:28

askarpets requested review from bazarnov and tolik0 and removed request for a team October 18, 2023 14:28

bazarnov approved these changes Oct 18, 2023

View reviewed changes

octavia-squidington-iv requested a review from a team October 18, 2023 15:28

erohmensing approved these changes Oct 18, 2023

View reviewed changes

askarpets added 2 commits October 19, 2023 09:52

Merge branch 'master' into source-klaviyo-add-missing-field

c6b1264

Update changelog

907cfda

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 19, 2023

vercel bot deployed to Preview October 19, 2023 07:05 View deployment

askarpets merged commit 03d7a90 into master Oct 19, 2023
28 checks passed

askarpets deleted the source-klaviyo-add-missing-field branch October 19, 2023 07:36

ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 20, 2023

🐛Source Klaviyo: add missing field (airbytehq#31562)

e5d5b85

ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023

🐛Source Klaviyo: add missing field (airbytehq#31562)

0882bd0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛Source Klaviyo: add missing field #31562

🐛Source Klaviyo: add missing field #31562

askarpets commented Oct 18, 2023

vercel bot commented Oct 18, 2023 •

edited

github-actions bot commented Oct 18, 2023 •

edited by askarpets

airbyte-oss-build-runner commented Oct 18, 2023

erohmensing left a comment

erohmensing Oct 18, 2023

erohmensing Oct 18, 2023

askarpets Oct 19, 2023

airbyte-oss-build-runner commented Oct 19, 2023

🐛Source Klaviyo: add missing field #31562

🐛Source Klaviyo: add missing field #31562

Conversation

askarpets commented Oct 18, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

vercel bot commented Oct 18, 2023 • edited

github-actions bot commented Oct 18, 2023 • edited by askarpets

Before Merging a Connector Pull Request

airbyte-oss-build-runner commented Oct 18, 2023

source-klaviyo test report (commit fd62eb6a8c) - ❌

erohmensing left a comment

Choose a reason for hiding this comment

erohmensing Oct 18, 2023

Choose a reason for hiding this comment

erohmensing Oct 18, 2023

Choose a reason for hiding this comment

askarpets Oct 19, 2023

Choose a reason for hiding this comment

airbyte-oss-build-runner commented Oct 19, 2023

source-klaviyo test report (commit 907cfda43e) - ✅

vercel bot commented Oct 18, 2023 •

edited

github-actions bot commented Oct 18, 2023 •

edited by askarpets

source-klaviyo test report (commit `fd62eb6a8c`) - ❌

source-klaviyo test report (commit `907cfda43e`) - ✅