Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate connectors to use our python base image (Round 2) #31599

Merged

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Oct 19, 2023

What

Migrate healthy certified python connectors (26) to use our base image and remove their dockerfiles

🚨 User Impact 🚨

None, if the connector CI passes it means:

  • The connector image was successfully built
  • The test passes: no functional regression of the connector commands

@alafanechere alafanechere requested a review from a team as a code owner October 19, 2023 08:16
@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 1:00pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 19, 2023
@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@airbyte-oss-build-runner
Copy link
Collaborator

source-chargebee test report (commit fa1640a991) - ❌

⏲️ Total pipeline duration: 05mn21s

Step Result
Build source-chargebee docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-chargebee
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-chargebee test

@airbyte-oss-build-runner
Copy link
Collaborator

source-notion test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 04mn01s

Step Result
Build source-notion docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-notion
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-notion test

@airbyte-oss-build-runner
Copy link
Collaborator

source-surveymonkey test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 03mn00s

Step Result
Build source-surveymonkey docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-surveymonkey
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-surveymonkey test

@airbyte-oss-build-runner
Copy link
Collaborator

source-google-analytics-v4 test report (commit fa1640a991) - ❌

⏲️ Total pipeline duration: 11mn59s

Step Result
Build source-google-analytics-v4 docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-google-analytics-v4
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-analytics-v4 test

@airbyte-oss-build-runner
Copy link
Collaborator

source-intercom test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 02mn14s

Step Result
Build source-intercom docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for source-intercom
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-intercom test

@airbyte-oss-build-runner
Copy link
Collaborator

destination-pinecone test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 01mn39s

Step Result
Build destination-pinecone docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for destination-pinecone
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-pinecone test

@airbyte-oss-build-runner
Copy link
Collaborator

source-harvest test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 19mn03s

Step Result
Build source-harvest docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-harvest
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-harvest test

@airbyte-oss-build-runner
Copy link
Collaborator

source-paypal-transaction test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 01mn25s

Step Result
Build source-paypal-transaction docker image for platform(s) linux/x86_64
Acceptance tests
Code format checks
Validate metadata for source-paypal-transaction
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-paypal-transaction test

@airbyte-oss-build-runner
Copy link
Collaborator

source-gitlab test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 12mn33s

Step Result
Build source-gitlab docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-gitlab
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-gitlab test

@airbyte-oss-build-runner
Copy link
Collaborator

source-amazon-ads test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 02mn23s

Step Result
Build source-amazon-ads docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-amazon-ads
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-amazon-ads test

@airbyte-oss-build-runner
Copy link
Collaborator

source-bing-ads test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 14mn05s

Step Result
Build source-bing-ads docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-bing-ads
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

@airbyte-oss-build-runner
Copy link
Collaborator

source-tiktok-marketing test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 43mn41s

Step Result
Build source-tiktok-marketing docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-tiktok-marketing
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-tiktok-marketing test

@airbyte-oss-build-runner
Copy link
Collaborator

source-shopify test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 15mn10s

Step Result
Build source-shopify docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-shopify
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-shopify test

@airbyte-oss-build-runner
Copy link
Collaborator

source-airtable test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 02mn27s

Step Result
Build source-airtable docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-airtable
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-airtable test

@airbyte-oss-build-runner
Copy link
Collaborator

source-google-sheets test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 03mn57s

Step Result
Build source-google-sheets docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-google-sheets
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-sheets test

@alafanechere
Copy link
Contributor Author

I think we can merge as the error are likely transient.
All the connectors in this PR got 🟢 test at least once on this branch. As we're not changing the connector logic I believe the intermittent failures are due to test flakyness.

@airbyte-oss-build-runner
Copy link
Collaborator

source-linkedin-ads test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 10mn41s

Step Result
Build source-linkedin-ads docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-linkedin-ads
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-linkedin-ads test

@airbyte-oss-build-runner
Copy link
Collaborator

source-typeform test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 02mn02s

Step Result
Build source-typeform docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-typeform
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-typeform test

@airbyte-oss-build-runner
Copy link
Collaborator

source-facebook-marketing test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 73mn07s

Step Result
Build source-facebook-marketing docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for source-facebook-marketing
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test

@airbyte-oss-build-runner
Copy link
Collaborator

source-slack test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 81mn22s

Step Result
Build source-slack docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-slack
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-slack test

@airbyte-oss-build-runner
Copy link
Collaborator

source-marketo test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 70mn26s

Step Result
Build source-marketo docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-marketo
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-marketo test

@airbyte-oss-build-runner
Copy link
Collaborator

source-mixpanel test report (commit fa1640a991) - ✅

⏲️ Total pipeline duration: 69mn12s

Step Result
Build source-mixpanel docker image for platform(s) linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate metadata for source-mixpanel
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mixpanel test

Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked with @alafanechere - these latest failures are all due to flakyness - the tests all passed on an earlier run of this PR.

@alafanechere alafanechere merged commit a41c4f5 into master Oct 19, 2023
43 of 51 checks passed
@alafanechere alafanechere deleted the augustin/certified-connectors-migration-to-base-image-2 branch October 19, 2023 15:58
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 20, 2023
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment