Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update connector tutorials to reference airbyte-ci for connector build #31650

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Oct 20, 2023

What

Closes #31648
Update our tutorial to reference airbyte-ci for connector build.

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 1:55pm

Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 20, 2023
@alafanechere alafanechere force-pushed the augustin/10-20-doc_update_connector_tutorials_to_reference_airbyte-ci_for_connector_build branch from b53b51f to ba4f19d Compare October 20, 2023 11:11
@alafanechere alafanechere requested review from marcosmarxm and a team October 20, 2023 11:12
@alafanechere alafanechere force-pushed the augustin/10-20-doc_update_connector_tutorials_to_reference_airbyte-ci_for_connector_build branch from ba4f19d to 071286c Compare October 20, 2023 11:14
@alafanechere alafanechere force-pushed the augustin/10-20-doc_update_connector_tutorials_to_reference_airbyte-ci_for_connector_build branch from 071286c to 9bb8493 Compare October 20, 2023 11:16
@alafanechere alafanechere marked this pull request as ready for review October 20, 2023 11:17

**Option B: Building the docker image with a Dockerfile**

If you don't want to rely on `airbyte-ci` to build your connector, you can build the docker image using your own Dockerfile.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you don't want to rely on `airbyte-ci` to build your connector, you can build the docker image using your own Dockerfile.
If you don't want to rely on `airbyte-ci` to build your connector, you can build the docker image using your own Dockerfile. This method is not preferred, and is not supported for certified connectors


**Option B: Building the docker image with a Dockerfile**

If you don't want to rely on `airbyte-ci` to build your connector, you can build the docker image using your own Dockerfile.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you don't want to rely on `airbyte-ci` to build your connector, you can build the docker image using your own Dockerfile.
If you don't want to rely on `airbyte-ci` to build your connector, you can build the docker image using your own Dockerfile. This method is not preferred, and is not supported for certified connectors


**Option B: Building the docker image with a Dockerfile**

If you don't want to rely on `airbyte-ci` to build your connector, you can build the docker image using your own Dockerfile.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you don't want to rely on `airbyte-ci` to build your connector, you can build the docker image using your own Dockerfile.
If you don't want to rely on `airbyte-ci` to build your connector, you can build the docker image using your own Dockerfile. This method is not preferred, and is not supported for certified connectors


**Option B: Building the docker image with a Dockerfile**

If you don't want to rely on `airbyte-ci` to build your connector, you can build the docker image using your own Dockerfile.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you don't want to rely on `airbyte-ci` to build your connector, you can build the docker image using your own Dockerfile.
If you don't want to rely on `airbyte-ci` to build your connector, you can build the docker image using your own Dockerfile. This method is not preferred, and is not supported for certified connectors

@alafanechere alafanechere force-pushed the augustin/10-20-doc_update_connector_tutorials_to_reference_airbyte-ci_for_connector_build branch from 3422149 to b833684 Compare October 23, 2023 13:54
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alafanechere

@alafanechere alafanechere merged commit b35a2b2 into master Oct 23, 2023
22 checks passed
@alafanechere alafanechere deleted the augustin/10-20-doc_update_connector_tutorials_to_reference_airbyte-ci_for_connector_build branch October 23, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update connector tutorial with airbyte-ci reference
4 participants