airbyte-ci: Fix CheckBaseImageIsUsed failing on non certified connectors #31653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
alafanechere
force-pushed
the
augustin/10-20-airbyte-ci_Fix_CheckBaseImageIsUsed_failing_on_non_certified_connectors
branch
from
d539d55
to
0d548f9
Compare
octavia-squidington-iii
added
area/connectors
flash1293
approved these changes
Oct 20, 2023
| @@ -23,3 +23,4 @@ data: | |||
| tags: | |||
| - language:lowcode | |||
| metadataSpecVersion: "1.0" | |||
| # TODO: revert | |||
|
| Step | Result |
|---|---|
| Build source-pokeapi docker image for platform(s) linux/x86_64 | ✅ |
| Acceptance tests | ❌ |
| Code format checks | ✅ |
| Validate metadata for source-pokeapi | ✅ |
| Connector version semver check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-pokeapi test
alafanechere
force-pushed
the
augustin/10-20-airbyte-ci_Fix_CheckBaseImageIsUsed_failing_on_non_certified_connectors
branch
from
0d548f9
to
ea706f0
Compare
alafanechere
deleted the
augustin/10-20-airbyte-ci_Fix_CheckBaseImageIsUsed_failing_on_non_certified_connectors
branch
ariesgun
pushed a commit
to ariesgun/airbyte
that referenced
this pull request
Oct 20, 2023
ariesgun
pushed a commit
to ariesgun/airbyte
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Our new check CheckBaseImageIsUsed should be skipped on non certified connectors.
It was not.