Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: fix migration hint #31688

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Oct 21, 2023

What

We wanted to add the pul request number in the migration hint command.
But this attribute is not available when running connector tests locally / on nightly builds.

How

Do not access the context.pull_request attribute in the CheckBaseImageUse step.

@vercel
Copy link

vercel bot commented Oct 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2023 9:51am

Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@alafanechere alafanechere marked this pull request as ready for review October 21, 2023 09:50
@alafanechere alafanechere requested a review from a team October 21, 2023 09:50
@alafanechere alafanechere force-pushed the augustin/10-21-airbyte-ci_fix_migration_hint branch from fa3d6e0 to e2074e8 Compare October 21, 2023 09:50
@alafanechere alafanechere force-pushed the augustin/10-21-airbyte-ci_fix_migration_hint branch from e2074e8 to 16d5aa9 Compare October 21, 2023 09:51
@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label Oct 21, 2023
@airbytehq airbytehq deleted a comment from github-actions bot Oct 21, 2023
@alafanechere alafanechere enabled auto-merge (squash) October 21, 2023 09:51
@alafanechere alafanechere merged commit 01cd0a8 into master Oct 21, 2023
21 checks passed
@alafanechere alafanechere deleted the augustin/10-21-airbyte-ci_fix_migration_hint branch October 21, 2023 11:09
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants