馃帀 Airbyte CDK: Add CustomFileBasedException for custom errors in file-based CDK #31704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌 1 Ignored Deployment
|
tolik0
force-pushed
the
tolik0/file-based-cdk/custom-exception
branch
from
3568482
to
b57b717
Compare
clnoll
approved these changes
Oct 23, 2023
tolik0
force-pushed
the
tolik0/file-based-cdk/custom-exception
branch
from
62b1c22
to
cc076f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add custom Exception that can be raised in file-based CDK. Example of use: #31383
How
Add a new type of error - CustomFileBasedException. Also, add catching this error in AbstractFileBasedAvailabilityStrategy and raise it as CheckAvailabilityError.
Recommended reading order
airbyte-cdk/python/airbyte_cdk/sources/file_based/exceptions.pyairbyte-cdk/python/airbyte_cdk/sources/file_based/exceptions.pyairbyte-cdk/python/unit_tests/sources/file_based/availability_strategy/test_default_file_based_availability_strategy.py