airbyte-ci: Add more info about setting up GSM secrets #31713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
bnchrch
reviewed
Oct 23, 2023
| @@ -105,7 +105,7 @@ def validate_environment(is_local: bool, use_remote_secrets: bool): | |||
| raise click.UsageError(f"When running in a CI context a {required_env_var} environment variable must be set.") | |||
| if use_remote_secrets and os.getenv("GCP_GSM_CREDENTIALS") is None: | |||
| raise click.UsageError( | |||
| "You have to set the GCP_GSM_CREDENTIALS if you want to download secrets from GSM. Set the --use-remote-secrets option to false otherwise." | |||
| "You have to set the GCP_GSM_CREDENTIALS if you want to download secrets from GSM. See README for instructions ('Setting up connector secrets access'). Set the --use-remote-secrets option to false otherwise." | |||
There was a problem hiding this comment.
📚 We could go as far as providing a link directly. But this seems more than enough!
Good call updating the error message
There was a problem hiding this comment.
I figured a link in a CLI which won't turn it into an actual link (will stay full url) is kind of annoying. But I could be wrong!
There was a problem hiding this comment.
I guess it depends on your terminal, but in iterm2 you can cmd+click urls which I do all the time so it would be a nice touch. However, I would have searched for Setting up connector secrets access in the repo based on this message and it would have turned up the right thing as well.
flash1293
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more info about setting up secrets right after airbyte ci setup - most people running airbyte ci probably want to do this.
From slack thread