Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: docker login on dockerd container to avoid rate limit #31718

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Oct 23, 2023

What

Java connector test rely on testcontainers.
testcontainers pulls images from DockerHub.
pulls from DockerHub is rate-limited.
We have to authenticate our DockerHost to DockerHub to avoid these rate limit issues.

How

Run docker login in with_global_dockerd_service

Testing

Running a test run on source-postgres

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2023 9:08pm

Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@alafanechere alafanechere force-pushed the augustin/10-23-airbyte-ci_docker_login_on_dockerd_container_to_avoid_rate_limit branch from 7e535a4 to 17aa7db Compare October 23, 2023 17:51
@alafanechere alafanechere marked this pull request as ready for review October 23, 2023 17:53
@alafanechere alafanechere requested review from a team and postamar October 23, 2023 17:53
@alafanechere alafanechere force-pushed the augustin/10-23-airbyte-ci_docker_login_on_dockerd_container_to_avoid_rate_limit branch 2 times, most recently from a45c222 to 62bea85 Compare October 23, 2023 18:13
@alafanechere alafanechere force-pushed the augustin/10-23-airbyte-ci_docker_login_on_dockerd_container_to_avoid_rate_limit branch from ff5d7f5 to 3334422 Compare October 23, 2023 21:07
@alafanechere alafanechere enabled auto-merge (squash) October 23, 2023 21:12
@alafanechere alafanechere merged commit f8ae6f3 into master Oct 23, 2023
20 checks passed
@alafanechere alafanechere deleted the augustin/10-23-airbyte-ci_docker_login_on_dockerd_container_to_avoid_rate_limit branch October 23, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants